Merged
Conversation
…ted on window focus change.
… additional backspace at the 0 index.
…-Android into issue/345-fixing-toolbar-highlight-issues # Conflicts: # aztec/src/main/kotlin/org/wordpress/aztec/AztecText.kt # aztec/src/main/kotlin/org/wordpress/aztec/toolbar/AztecToolbar.kt # aztec/src/test/kotlin/org/wordpress/aztec/HeadingTest.kt
…-Android into issue/345-fixing-toolbar-highlight-issues # Conflicts: # aztec/src/main/kotlin/org/wordpress/aztec/toolbar/AztecToolbar.kt
…-Android into issue/345-fixing-toolbar-highlight-issues
…-Android into issue/345-fixing-toolbar-highlight-issues
…-Android into feature/run-ui-tests-with-travis
…ss-mobile/WordPress-Aztec-Android into issue/345-fixing-toolbar-highlight-issues
…-Android into feature/run-ui-tests-with-travis
…ss-mobile/WordPress-Aztec-Android into issue/345-fixing-toolbar-highlight-issues
Contributor
Author
|
This also fixes #362 |
…-Android into issue/345-fixing-toolbar-highlight-issues # Conflicts: # aztec/src/main/kotlin/org/wordpress/aztec/formatting/InlineFormatter.kt
Contributor
|
For Test 2, after step 4 the style gets deselected automatically. Isn't that intentional? |
…-Android into issue/345-fixing-toolbar-highlight-issues
Contributor
Author
|
Yes! It's intentional. Sorry, I copied the steps from the issue without changing them to reflect fixes :) |
Contributor
|
Nice work! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#395 need's to be merged before this one.
Fixes #345
Fixes #357
Preserves selected style when deleting the last character on 0 index, and allows the selected style to be removed with extra backspace.
Test 1
Test 2
Test 3
There are a couple of changes to inline style handling, so it would be awesome if both @0nko and @theck13 could play with inline styles a bit to make sure everything is ok.