This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Refactor Product Query to use the latest Gutenberg APIs#7169
Merged
sunyatasattva merged 4 commits intotrunkfrom Sep 23, 2022
Merged
Refactor Product Query to use the latest Gutenberg APIs#7169sunyatasattva merged 4 commits intotrunkfrom
sunyatasattva merged 4 commits intotrunkfrom
Conversation
As we worked with Gutenberg folks in WordPress/gutenberg#43590, WordPress/gutenberg#/43632 and WordPress/gutenberg#/44093 we have created a standard API that could be used for our use-case. This PR refactors our WIP experimental work to use that standardized API.
Contributor
|
The release ZIP for this PR is accessible via: |
Contributor
|
Size Change: +19 kB (+2%) Total Size: 893 kB
ℹ️ View Unchanged
|
Contributor
The Gutenberg feature plugin needs to be enabled for the PQ block to show up in the inserter. It also required
This does not seem to be functioning, as described: CleanShot.2022-09-22.at.15.47.23.mp4 |
danielwrobert
approved these changes
Sep 23, 2022
Contributor
danielwrobert
left a comment
There was a problem hiding this comment.
LGTM!
Your latest commit fixes the sale toggle and now everything tests as described.
Nice work! 
Contributor
Author
|
Amazing! Thanks for the review @danielwrobert ! |
|
👋 - There is going to be a small change to this newly created API here: WordPress/gutenberg#44523. There is going to be a rename from |
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
…7169) * Refactor Product Query to use the latest Gutenberg APIs As we worked with Gutenberg folks in WordPress/gutenberg#43590, WordPress/gutenberg#43632 and WordPress/gutenberg#44093 we have created a standard API that could be used for our use-case. This PR refactors our WIP experimental work to use that standardized API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we worked with Gutenberg folks in WordPress/gutenberg#43590, WordPress/gutenberg#43632 and WordPress/gutenberg#44093 we have created a standard API that could be used for our use-case. This PR refactors our WIP experimental work to use that standardized API.
Screenshots
Testing
Automated Tests
User Facing Testing
Layout,Columns,Order by,Filters > Keywords,Filters > Taxonomies,Show Products on Sale,Color,Advanced(see screenshot above).Show Products on Saletoggle (see screenshot above).WooCommerce Visibility