Bump coroutines version to 1.6 by malinajirka · Pull Request #6292 · woocommerce/woocommerce-android

malinajirka · 2022-04-19T03:24:11Z

Bumps coroutinesVersion from 1.5.2 to 1.6.1.

Updates kotlinx-coroutines-core from 1.5.2 to 1.6.1

Updates kotlinx-coroutines-android from 1.5.2 to 1.6.1

Updates kotlinx-coroutines-test from 1.5.2 to 1.6.1 + migration guide

I was not able to migrate ReviewModerationHandlerTests.kt. I tried several different approaches using both Standard and Unconfined dispatchers, but at least 3 tests were always failing. I'm probably missing something or the tests need to be rewritten. I decided to give up for now, since the tests work with the original approach.

Again, it is recommended to review this commit by commit to follow my train of thoughts. I'm sorry for the number of changes - I didn't realize that tests which live in the CardReaderModule are not using any BaseUnitTest class. Let me know if you'd prefer me to split it into two PRs.

Bumps `coroutinesVersion` from 1.5.2 to 1.6.1. Updates `kotlinx-coroutines-core` from 1.5.2 to 1.6.1 - [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases) - [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md) - [Commits](Kotlin/kotlinx.coroutines@1.5.2...1.6.1) Updates `kotlinx-coroutines-android` from 1.5.2 to 1.6.1 - [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases) - [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md) - [Commits](Kotlin/kotlinx.coroutines@1.5.2...1.6.1) Updates `kotlinx-coroutines-test` from 1.5.2 to 1.6.1 - [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases) - [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md) - [Commits](Kotlin/kotlinx.coroutines@1.5.2...1.6.1) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-core dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-android dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-test dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

peril-woocommerce · 2022-04-19T03:24:16Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

wpmobilebot · 2022-04-19T03:37:09Z

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

malinajirka · 2022-04-19T03:43:10Z

...mmerce/android/ui/orders/creation/variations/OrderCreationVariationSelectionViewModelTest.kt

                if (index == 0) productVariation.copy(price = null) else productVariation
            }
-        whenever(variationsRepository.fetchProductVariations(PRODUCT_ID))
+        whenever(variationsRepository.getProductVariationList(PRODUCT_ID))


ℹ️ It seems the goal of this test is to check that variations without price are filtered out.

The order in which the coroutines are processed in this test has changed and viewModel.viewState.getOrAwaitValue() returns the first value which is set - that's 5 items with a price. This PR changes the mocked value and returns a list with one item without a price for getProductVariationList to fix the test.

I don't think the right fix is to change the mocked function, as if you check the implementation, we start by emitting the cached values, then we fetch the updated values from network, which means these last values are the ones we care about.

I think after changing the scheduler, the asLiveData behavior changed too (as it uses the Main.immediate dispatcher), and now it receives the two values explicitly, where before it probably did some conflating, and received only the last value. With this in mind, the getOrAwaitValue doesn't work anymore, as it will just return the first element.

So to fix the test, without changing its behavior, we can do something like this:

@Test fun `when loading variations, then exclude any variations without price`() = testBlocking { val variations = ProductTestUtils.generateProductVariationList(PRODUCT_ID) .mapIndexed { index, productVariation -> if (index == 0) productVariation.copy(price = null) else productVariation } whenever(variationsRepository.fetchProductVariations(PRODUCT_ID)) .thenReturn(variations) var displayedVariations: List<ProductVariation>? = null viewModel.viewState.observeForever { displayedVariations = it.variationsList } assertThat(displayedVariations).allMatch { it.price != null } assertThat(displayedVariations?.size).isEqualTo(variations.size - 1) }

WDYT?

Thanks for sharing your thoughts and the code 🙇 !

think after changing the scheduler, the asLiveData behavior changed too (as it uses the Main.immediate dispatcher), and now it receives the two values explicitly, where before it probably did some conflating, and received only the last value. With this in mind, the getOrAwaitValue doesn't work anymore, as it will just return the first element.

My train of thoughts was the same.

I don't think the right fix is to change the mocked function, as if you check the implementation, we start by emitting the cached values, then we fetch the updated values from network, which means these last values are the ones we care about.

Yes, but it seems the goal of the test is to check that items are filtered not that first a cached value is emitted and then a data from the remote are emitted -> that's why I opted for changing the test, it imho also better corresponds with the test name which says "loading variations" not "fetching variations".

Anyway, if you agree I opted for another solution - I added the code you shared as a new test. So we check both cases and are 100% sure it works as expected. ea761d0

malinajirka · 2022-04-19T03:44:20Z

WooCommerce/src/test/kotlin/com/woocommerce/android/ui/reviews/ReviewModerationHandlerTests.kt

 import org.wordpress.android.fluxc.store.WCProductStore

-class ReviewModerationHandlerTests : BaseUnitTest() {
+class ReviewModerationHandlerTests {


I wasn't able to make this test suite work with the new approach - decided to revert to the original.

I can work on this in a separate PR.

I think there are two reasons for issues with the tests on this class:

The main reason is the use of UnconfinedTestScheduler as parameter for runTest, as it's impossible to dictate the order of execution when using it, where this test suite depends on the order a lot.

The second reason is not being able to collect all items without conflating from the exposed states flow, and this is also related to the used Dispatcher (there are a some tickets about this in the Github repo of the library: How to test all intermediate emissions despite conflation Kotlin/kotlinx.coroutines#3120, as it's a bit confusing)

The main reason is the use of UnconfinedTestScheduler as parameter for runTest, as it's impossible to dictate the order of execution when using it, where this test suite depends on the order a lot.

I tried making it work even with the StandardTestDispatcher which uses the standardScheduler (even with a combination of the dispatchers). However, I think one vital mistake I did was that I forgot that there were two similar methods runTestAndReturnLastEmittedStatusList and runTestAndCollectAllStatuses - n/c 😞 .

I can work on this in a separate PR

That'd be awesome, thanks so much! Or we could do a pair programming session on this, I think it might be valuable for me :).

wzieba · 2022-04-20T10:10:21Z

@malinajirka if it's something you'd like to try, #6251 (hopefully) fixed CodeCov integration. I think it could work if you'll merge the current trunk 🙂.

hichamboushaba

Thanks for working on this @malinajirka, this took me very long to review, because I had to learn about the new APIs before, but it's worth it.
I'm pre-approving the PR, I left some comments, but nothing is blocking, great job.

hichamboushaba · 2022-04-20T14:39:57Z

.../src/test/kotlin/com/woocommerce/android/ui/orders/creation/CreateOrUpdateOrderDraftTests.kt

        advanceTimeBy(CreateOrUpdateOrderDraft.DEBOUNCE_DURATION_MS)
+        runCurrent()


I wonder if an extension like the one below can be useful to avoid having to make calls like this with the new scheduler behavior?

fun TestScope.advanceTimeAndRun(duration: Long) { advanceTimeBy(duration) runCurrent() }

And an np comment, I think the deleted empty line should be restored to separate the "act" part from the "assert" one.

I wonder if an extension like the one below can be useful to avoid having to make calls like this with the new scheduler behavior?

Great idea, added in 8299348 and d606d82

And an np comment, I think the deleted empty line should be restored to separate the "act" part from the "assert" one.

I'm not sure which deleted empty line you mean - I don't see any such change in this class. Either way, feel free to update the code or let me know and I'll update it.

I'm not sure which deleted empty line you mean

I must've been looking at different line while writing the comment 😅 🤦, please ignore this part.

hichamboushaba · 2022-04-20T14:58:31Z

...mmerce/android/ui/orders/creation/variations/OrderCreationVariationSelectionViewModelTest.kt

                if (index == 0) productVariation.copy(price = null) else productVariation
            }
-        whenever(variationsRepository.fetchProductVariations(PRODUCT_ID))
+        whenever(variationsRepository.getProductVariationList(PRODUCT_ID))


I don't think the right fix is to change the mocked function, as if you check the implementation, we start by emitting the cached values, then we fetch the updated values from network, which means these last values are the ones we care about.

I think after changing the scheduler, the asLiveData behavior changed too (as it uses the Main.immediate dispatcher), and now it receives the two values explicitly, where before it probably did some conflating, and received only the last value. With this in mind, the getOrAwaitValue doesn't work anymore, as it will just return the first element.

So to fix the test, without changing its behavior, we can do something like this:

@Test fun `when loading variations, then exclude any variations without price`() = testBlocking { val variations = ProductTestUtils.generateProductVariationList(PRODUCT_ID) .mapIndexed { index, productVariation -> if (index == 0) productVariation.copy(price = null) else productVariation } whenever(variationsRepository.fetchProductVariations(PRODUCT_ID)) .thenReturn(variations) var displayedVariations: List<ProductVariation>? = null viewModel.viewState.observeForever { displayedVariations = it.variationsList } assertThat(displayedVariations).allMatch { it.price != null } assertThat(displayedVariations?.size).isEqualTo(variations.size - 1) }

WDYT?

hichamboushaba · 2022-04-20T15:57:00Z

WooCommerce/src/test/kotlin/com/woocommerce/android/ui/reviews/ReviewModerationHandlerTests.kt

 import org.wordpress.android.fluxc.store.WCProductStore

-class ReviewModerationHandlerTests : BaseUnitTest() {
+class ReviewModerationHandlerTests {


I can work on this in a separate PR.

I think there are two reasons for issues with the tests on this class:

The main reason is the use of UnconfinedTestScheduler as parameter for runTest, as it's impossible to dictate the order of execution when using it, where this test suite depends on the order a lot.

The second reason is not being able to collect all items without conflating from the exposed states flow, and this is also related to the used Dispatcher (there are a some tickets about this in the Github repo of the library: How to test all intermediate emissions despite conflation Kotlin/kotlinx.coroutines#3120, as it's a bit confusing)

hichamboushaba · 2022-04-20T16:01:44Z

WooCommerce/src/test/kotlin/com/woocommerce/android/util/CoroutineTestRule.kt


 @ExperimentalCoroutinesApi
-class CoroutineTestRule(val testDispatcher: TestCoroutineDispatcher = TestCoroutineDispatcher()) : TestWatcher() {
+class CoroutineTestRule(val testDispatcher: TestDispatcher = UnconfinedTestDispatcher()) : TestWatcher() {


A suggestion: while I agree that using UnconfinedTestDispatcher is a good default for most of our test cases, it shouldn't be the only way, some tests require some definite and explicit ordering (like the ReviewModerationHandlerTests above), and those would benefit from using StandardTestDispatcher.
So I suggest removing the default value from here, and adding an argument to specify the dispatcher in BaseUnitTest with UnconfinedTestDispatcher as a default value, this would allow child test classes to change the dispatcher easily.

Great suggestion! I actually had this implemented while trying to fix the reviewHandler tests but reverted it with all the other changes I made. Fixed in f6662b2

hichamboushaba · 2022-04-20T16:03:07Z

...rdreader/src/test/java/com/woocommerce/android/cardreader/internal/CardReaderBaseUnitTest.kt

+
+@Suppress("UnnecessaryAbstractClass")
+@RunWith(MockitoJUnitRunner::class)
+abstract class CardReaderBaseUnitTest {


I wonder if we shouldn't have a core module for things that need to be part of all modules? Maybe we can start with a core-testing just for test helpers? Not necessarily on this PR though.

Yeah, I think it'd be great but might need a little more work. Especially when it comes to documentation - we need to make sure we use it correctly and don't add everything that needs to be shared by at least 2 modules there.

hichamboushaba · 2022-04-20T16:12:09Z

Another point, I think before merging this, you should make sure you are up-to-date with trunk, to avoid breaking tests that were added after creating your branch.

codecov-commenter · 2022-04-21T03:11:38Z

Codecov Report

Merging #6292 (19f2c63) into trunk (567742f) will increase coverage by 0.28%.
The diff coverage is n/a.

❗ Current head 19f2c63 differs from pull request most recent head 03cba20. Consider uploading reports for the commit 03cba20 to get more accurate results

@@             Coverage Diff              @@
##              trunk    #6292      +/-   ##
============================================
+ Coverage     24.59%   24.87%   +0.28%     
+ Complexity     2602     2587      -15     
============================================
  Files           786      786              
  Lines         45920    46087     +167     
  Branches       5819     5890      +71     
============================================
+ Hits          11292    11466     +174     
+ Misses        33575    33539      -36     
- Partials       1053     1082      +29

Impacted Files	Coverage Δ
.../simplepayments/SimplePaymentsFragmentViewModel.kt	`44.66% <0.00%> (-9.46%)`	⬇️
...ardreader/internal/connection/ConnectionManager.kt	`84.00% <0.00%> (-7.49%)`	⬇️
...ui/orders/details/editing/OrderEditingViewModel.kt	`80.59% <0.00%> (-1.86%)`	⬇️
...s/cardreader/payment/CardReaderPaymentViewModel.kt	`89.67% <0.00%> (-1.44%)`	⬇️
...oid/cardreader/internal/payments/PaymentManager.kt	`86.02% <0.00%> (-1.16%)`	⬇️
...erce/android/ui/reviews/ReviewModerationHandler.kt	`87.73% <0.00%> (-0.84%)`	⬇️
...droid/ui/orders/creation/OrderCreationViewModel.kt	`88.88% <0.00%> (-0.73%)`	⬇️
.../android/ui/orders/details/OrderDetailViewModel.kt	`65.23% <0.00%> (-0.31%)`	⬇️
...erce/android/ui/products/ProductDetailViewModel.kt	`38.93% <0.00%> (-0.18%)`	⬇️
...ain/kotlin/com/woocommerce/android/model/Coupon.kt	`46.42% <0.00%> (-0.13%)`	⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567742f...03cba20. Read the comment docs.

peril-woocommerce · 2022-04-21T03:11:46Z

	Fails
🚫	Danger failed to run `/app/danger-0.9e43wa4taeh.ts`.

Error TypeError

Cannot read property 'diffForFile' of undefined
TypeError: Cannot read property 'diffForFile' of undefined
    at Object.exports.default (/app/danger-0.9e43wa4taeh.ts:27:46)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

22|     // Calculate the changes to Test files because we don't want to limit those
23|     // Note that linesOfCode() function in the latest GitDSL can solve this problem in a more elegant way,
24|     // but the version of Danger currently used by Peril doesn't have it yet.
25|     const testFiles = [...modifiedFiles, ...createdFiles, ...deletedFiles].filter((path: string) => path.includes("/src/test"));
26|     let changesToTests = 0;
------------------------------------------------^
27|     for (let file of testFiles) {        
28|         const stringDiffs = await danger.git.diffForFile(file)
29|         const addedLines = stringDiffs.added.split("\n").filter(x => x.startsWith("+")).length;
30|         const removedLines = stringDiffs.removed.split("\n").filter(x => x.startsWith("-")).length;

Generated by 🚫 dangerJS

WooCommerce/src/test/kotlin/com/woocommerce/android/tracker/SendTelemetryTest.kt

.../src/test/kotlin/com/woocommerce/android/ui/orders/creation/CreateOrUpdateOrderDraftTests.kt

malinajirka · 2022-04-21T03:46:45Z

Thanks so much for the great review @hichamboushaba! Truly appreciate the time you spent on this 🙇.

I've implemented most of the suggestions you proposed, great tips! I've also merged trunk into the branch and double checked no new tests which would be affected by the changes were added. Essentially, the only thing I didn't implement is creating a separate "core" module.

I think it'd be great if you checked the commits I added before we merge this just to be sure I didn't mess anything up. I'll update it with trunk one more time before the final merge, let me know. Thanks so much!!!

Btw I forgot to mention it in the description - this PR changes not just the test package but also the core coroutine package -> if you haven't tested the app it might be worth testing. I run some tests and haven't noticed anything weird.

hichamboushaba

Looks great, thanks for the changes @malinajirka

wpmobilebot · 2022-04-25T07:16:22Z

Found 1 violations:

The PR caused the following dependency changes:

expand

 +--- androidx.legacy:legacy-support-v4:1.0.0
 |    \--- androidx.legacy:legacy-support-core-ui:1.0.0
 |         \--- androidx.slidingpanelayout:slidingpanelayout:1.0.0 -> 1.2.0
 |              \--- androidx.window:window:1.0.0
-|                   \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2
-|                        +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2
-|                        |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.5.2
-|                        |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
-|                        |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.30 -> 1.6.10
-|                        \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
+|                   \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1
+|                        +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.1
+|                        |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.1
+|                        |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.1
+|                        |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 (c)
+|                        |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.1 (c)
+|                        |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.1 (c)
+|                        |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-rx2:1.6.1 (c)
+|                        |         |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-reactive:1.6.1 (c)
+|                        |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.0 -> 1.6.10 (*)
+|                        |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0 -> 1.6.10
+|                        +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.1 (*)
+|                        \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.0 -> 1.6.10 (*)
 +--- androidx.datastore:datastore-preferences:1.0.0
 |    \--- androidx.datastore:datastore:1.0.0
-|         +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.0 -> 1.5.2 (*)
+|         +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.0 -> 1.6.1 (*)
 |         \--- androidx.datastore:datastore-core:1.0.0
-|              \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.0 -> 1.5.2 (*)
+|              \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.0 -> 1.6.1 (*)
 +--- androidx.navigation:navigation-fragment-ktx:2.4.1
 |    \--- androidx.navigation:navigation-fragment:2.4.1
 |         \--- androidx.fragment:fragment-ktx:1.4.1
 |              \--- androidx.activity:activity-ktx:1.2.3 -> 1.4.0
 |                   +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1
-|                   |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.4.1 -> 1.5.2 (*)
+|                   |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.4.1 -> 1.6.1 (*)
 |                   \--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.0
-|                        \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.5.2 (*)
+|                        \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.6.1 (*)
 +--- org.wordpress:fluxc:trunk-4b7a896b6713caef932133d3a93b8117b414d253
 |    +--- androidx.room:room-ktx:2.4.2
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.5.2 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.6.1 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.5.2 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.6.1 (*)
 +--- org.wordpress.fluxc.plugins:woocommerce:trunk-4b7a896b6713caef932133d3a93b8117b414d253
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.5.2 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.6.1 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.5.2 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.6.1 (*)
 +--- com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:v1.3.45
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.1.0 -> 1.5.2 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.1.0 -> 1.6.1 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.1.0 -> 1.5.2 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.1.0 -> 1.6.1 (*)
 +--- project :libs:cardreader
 |    +--- com.stripe:stripeterminal:2.6.0
 |    |    \--- com.stripe:stripeterminal-core:2.6.0
 |    |         +--- com.stripe:stripeterminal-internal-common:2.6.0
-|    |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
-|    |         |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2 (*)
+|    |         |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2 -> 1.6.1 (*)
-|    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-rx2:1.5.2
-|    |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2 (*)
-|    |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-reactive:1.5.2
-|    |         |    |    +--- org.reactivestreams:reactive-streams:1.0.3
-|    |         |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2 (*)
-|    |         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
-|    |         |    +--- io.reactivex.rxjava2:rxjava:2.2.8 -> 2.2.21 (*)
-|    |         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
+|    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-rx2:1.5.2 -> 1.6.1
+|    |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.1 (*)
+|    |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.1 (*)
+|    |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-reactive:1.6.1
+|    |         |    |    +--- org.reactivestreams:reactive-streams:1.0.3
+|    |         |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.1 (*)
+|    |         |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.1 (*)
+|    |         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.0 -> 1.6.10 (*)
+|    |         |    +--- io.reactivex.rxjava2:rxjava:2.2.8 -> 2.2.21 (*)
+|    |         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.0 -> 1.6.10 (*)
 |    |         \--- androidx.lifecycle:lifecycle-livedata-ktx:2.4.0 -> 2.4.1
-|    |              \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.0 -> 1.5.2 (*)
+|    |              \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.0 -> 1.6.1 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.1 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 (*)
 +--- com.automattic:about:0.0.4
 |    +--- androidx.compose.ui:ui:1.0.5 -> 1.1.1
 |    |    +--- androidx.compose.runtime:runtime-saveable:1.1.1
 |    |    |    \--- androidx.compose.runtime:runtime:1.1.1
-|    |    |         \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    |    |         \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2 (*)
+|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2 -> 1.6.1 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
 |    \--- androidx.compose.ui:ui-tooling:1.0.5 -> 1.1.1
 |         \--- androidx.compose.animation:animation:1.1.1
 |              \--- androidx.compose.animation:animation-core:1.1.1
-|                   \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2 (*)
+|                   \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2 -> 1.6.1 (*)
-+--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2 (*)
++--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.1 (*)
-+--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
++--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 (*)
 +--- org.wordpress:mediapicker:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601
 |    +--- org.wordpress.mediapicker:domain:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
 +--- org.wordpress.mediapicker:source-device:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
 \--- org.wordpress.mediapicker:source-wordpress:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601
-     \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+     \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)

Please review and act accordingly

This 'ReviewModerationHandlerTests' test suite is the only such suite that still uses the old way of testing with Coroutines. As part of the Coroutine 1.6 PR (see link below), migrating this test suite to the new way didn't happen as different approaches using both 'Standard' and 'Unconfined' dispatchers didn't work, 3 tests were always failing. PR Link: #6292 Also, a TODO comment with an assignee was added to resolve this suppress warning. Issue: Resolve suppressed Coroutines related 'DEPRECATION' warning for 'ReviewModerationHandlerTests' Link: #6899

dependabot bot and others added 11 commits April 18, 2022 14:27

Update advanceXyz imports

47d2651

Use runTest and UnconfinedTestDispatcher

c6eab3e

Replace TestCoroutineScope with TestScope

6bfd1b5

Minor fixes

3338409

Update failing tests

ed98cec

Introduce BaseUnitTest in CardReaderModule

9726e39

Use runTest in CardReaderModule

b298be9

Remove unnecessary stubbings

cb50a75

Fix CardReaderPaymentViewModelTests

4548239

Revert ReviewModerationHandlerTests to deprecated approach

e939a41

malinajirka added the bot: dependencies update PRs that update a dependency file, used by Dependabot. label Apr 19, 2022

malinajirka added this to the 9.1 milestone Apr 19, 2022

Fix detekt

9f2655b

malinajirka requested a review from hichamboushaba April 19, 2022 03:27

malinajirka marked this pull request as ready for review April 19, 2022 03:27

malinajirka commented Apr 19, 2022

View reviewed changes

hichamboushaba self-assigned this Apr 19, 2022

hichamboushaba approved these changes Apr 20, 2022

View reviewed changes

hichamboushaba removed their assignment Apr 20, 2022

Add new test to OrderCreationVariationSelection suite

ea761d0

malinajirka added 2 commits April 21, 2022 10:26

Introduce advanceTimeAndRun extension method

8299348

Add support for setting a custom dispatcher

f6662b2

malinajirka added 2 commits April 21, 2022 10:34

Merge branch 'trunk' into bump-coroutines-version-to-1.6

341beb3

Move CoroutineTestUtils to unit test package

d606d82

wpmobilebot reviewed Apr 21, 2022

View reviewed changes

WooCommerce/src/test/kotlin/com/woocommerce/android/tracker/SendTelemetryTest.kt Show resolved Hide resolved

wpmobilebot reviewed Apr 21, 2022

View reviewed changes

.../src/test/kotlin/com/woocommerce/android/ui/orders/creation/CreateOrUpdateOrderDraftTests.kt Outdated Show resolved Hide resolved

malinajirka requested a review from hichamboushaba April 21, 2022 03:46

malinajirka added 2 commits April 21, 2022 10:47

Fix detekt

fdf3029

Add missing import

19f2c63

hichamboushaba approved these changes Apr 21, 2022

View reviewed changes

Merge branch 'trunk' into bump-coroutines-version-to-1.6

03cba20

malinajirka enabled auto-merge April 25, 2022 07:14

malinajirka merged commit d03d018 into trunk Apr 25, 2022

malinajirka deleted the bump-coroutines-version-to-1.6 branch April 25, 2022 07:28

ParaskP7 mentioned this pull request Jul 8, 2022

Resolve suppressed Coroutines related DEPRECATION warning for ReviewModerationHandlerTests #6899

Closed

malinajirka mentioned this pull request Nov 18, 2022

Add option update simulator UI #7735

Merged

1 task

ParaskP7 mentioned this pull request Dec 15, 2022

[Dependency Updates] Update kotlinxCoroutinesVersion to 1.6.4 wordpress-mobile/WordPress-Android#17673

Merged

8 tasks

		advanceTimeBy(CreateOrUpdateOrderDraft.DEBOUNCE_DURATION_MS)
		runCurrent()

Conversation

malinajirka commented Apr 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-woocommerce bot commented Apr 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Apr 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

malinajirka Apr 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wzieba commented Apr 20, 2022

Uh oh!

hichamboushaba left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

malinajirka Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hichamboushaba commented Apr 20, 2022

Uh oh!

codecov-commenter commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

peril-woocommerce bot commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Error TypeError

Dangerfile

Uh oh!

Uh oh!

Uh oh!

malinajirka commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hichamboushaba left a comment

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Apr 25, 2022

The PR caused the following dependency changes:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

malinajirka commented Apr 19, 2022 •

edited

Loading

peril-woocommerce bot commented Apr 19, 2022 •

edited

Loading

wpmobilebot commented Apr 19, 2022 •

edited

Loading

malinajirka Apr 19, 2022 •

edited

Loading

malinajirka Apr 21, 2022 •

edited

Loading

codecov-commenter commented Apr 21, 2022 •

edited

Loading

peril-woocommerce bot commented Apr 21, 2022 •

edited

Loading

malinajirka commented Apr 21, 2022 •

edited

Loading