Update navigation library by hichamboushaba · Pull Request #5521 · woocommerce/woocommerce-android

hichamboushaba · 2021-12-24T09:14:44Z

This update is blocked by the pending PR #5755

Description

The beta version of navigation had a bug that prevented restoring custom Parcelables from the saved state, which resulted in using a workaround to prevent the crash.
Now, Google has fixed the bug we reported in the new RC version, this PR updates the navigation library, and removes the previous workaround.

Testing instructions

Confirm the previous bug is fixed:

Enable "Don't keep activities" from the developer options.
Open Product Images screen of on the products.
Navigate to another app, then re-open the app.
Confirm that the app doesn't crash.

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

peril-woocommerce · 2021-12-24T09:25:08Z

You can test the changes on this Pull Request by downloading the APK here.

wzieba · 2021-12-24T14:35:43Z

hi @hichamboushaba 👋 I've looked at this PR wondering what's the cause of failing build. For some reason, safeargs bumped up Kotlin Gradle Plugin for the whole project and by this, Kotlin to version 1.6.0 as standard library is shipped with Gradle Plugin. See:

trunk	update-navigation

I'm wondering if it's similar to #5490 but couldn't find a quick solution for that. I can check that in details in next week.

hichamboushaba · 2021-12-24T14:37:44Z

Thanks @wzieba, yes, you are right, I've spent the whole morning trying to force the kotlin plugin version, but I came up empty.
I added some code to enforce the kotlin runtime dependencies, and the build issue is easy to fix, but I still think it's a workaround, and the real fix would be to enforce our own version of the plugin.

wzieba · 2021-12-24T16:17:01Z

I'm still wondering what can be the issue, I've checked commit before Plugin DSL migration (28ab96e) and the issue is the same. I'm leaning toward idea that there's something wrong with navigation-safe-args-gradle-plugin in rc01 but haven't had a chance to peak up the source yet.

hichamboushaba · 2021-12-24T16:21:00Z

Yes, I think the cause is from the rc01, I'm pretty sure they updated to kotlin 1.6.0, and it gets applied to us as well.
I just didn't find a way to force our version.

Next week I'll try another thing, using the non-kotlin version of the safeargs library, I don't think we need the kotlin version, since we use our own version of the NavArgsLazy 🤔

wpmobilebot · 2022-01-14T17:24:33Z

Found 1 violations:

The PR caused the following dependency changes:

-+--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31
-|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0
-|    |    +--- org.jetbrains:annotations:13.0 -> 16.0.1
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0
-|    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.5.31
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
++--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.0 -> 1.5.31
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31
+|    |    +--- org.jetbrains:annotations:13.0 -> 16.0.1
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.31
+|    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.5.31
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 (*)
 +--- com.google.firebase:firebase-messaging-ktx:23.0.0
 |    \--- com.google.android.gms:play-services-basement:17.2.1 -> 18.0.0
 |         \--- androidx.fragment:fragment:1.0.0 -> 1.4.0
 |              +--- androidx.core:core-ktx:1.2.0 -> 1.7.0
-|              |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
+|              |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 (*)
 |              +--- androidx.loader:loader:1.0.0
 |              |    \--- androidx.lifecycle:lifecycle-viewmodel:2.0.0 -> 2.4.0
-|              |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.0 (*)
+|              |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.5.31 (*)
-|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
+|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 (*)
 +--- androidx.legacy:legacy-support-v4:1.0.0
 |    \--- androidx.legacy:legacy-support-core-ui:1.0.0
-|         \--- androidx.slidingpanelayout:slidingpanelayout:1.0.0 -> 1.2.0-beta01
-|              +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|              +--- androidx.customview:customview:1.1.0 (*)
-|              +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
-|              +--- androidx.window:window:1.0.0-beta02
-|              |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.6.0 (*)
-|              |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.5.2
-|              |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2
-|              |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.5.2
-|              |    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.5.31 (*)
-|              |    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.30 -> 1.6.0
-|              |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.5.31 (*)
-|              |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|              |    +--- androidx.collection:collection:1.1.0 (*)
-|              |    \--- androidx.core:core:1.3.2 -> 1.7.0 (*)
-|              \--- androidx.transition:transition:1.4.1
-|                   +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|                   +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
-|                   \--- androidx.collection:collection:1.1.0 (*)
+|         \--- androidx.slidingpanelayout:slidingpanelayout:1.0.0 -> 1.2.0-rc01
+|              +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|              +--- androidx.customview:customview:1.1.0 (*)
+|              +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|              +--- androidx.window:window:1.0.0-rc01
+|              |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
+|              |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2
+|              |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2
+|              |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.5.2
+|              |    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.5.31 (*)
+|              |    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.30 -> 1.5.31
+|              |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.5.31 (*)
+|              |    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|              |    +--- androidx.collection:collection:1.1.0 (*)
+|              |    \--- androidx.core:core:1.3.2 -> 1.7.0 (*)
+|              \--- androidx.transition:transition:1.4.1
+|                   +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|                   +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|                   \--- androidx.collection:collection:1.1.0 (*)
 +--- androidx.datastore:datastore-preferences:1.0.0
-|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.10 -> 1.6.0 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.10 -> 1.5.31 (*)
 |    +--- androidx.datastore:datastore:1.0.0
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.10 -> 1.6.0 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.10 -> 1.5.31 (*)
 |    |    \--- androidx.datastore:datastore-core:1.0.0
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.10 -> 1.6.0 (*)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.10 -> 1.5.31 (*)
 |    \--- androidx.datastore:datastore-preferences-core:1.0.0
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.10 -> 1.6.0 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.10 -> 1.5.31 (*)
-+--- androidx.navigation:navigation-fragment-ktx:2.4.0-beta02
-|    +--- androidx.navigation:navigation-fragment:2.4.0-beta02
-|    |    +--- androidx.fragment:fragment-ktx:1.4.0-rc01 -> 1.4.0
-|    |    |    +--- androidx.fragment:fragment:1.4.0 (*)
-|    |    |    +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1
-|    |    |    |    +--- androidx.activity:activity:1.3.1 (*)
-|    |    |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1
-|    |    |    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.4.0 (*)
-|    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.0 (*)
-|    |    |    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.4.1 -> 1.5.2 (*)
-|    |    |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.0
-|    |    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.4.0 (*)
-|    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.0 (*)
-|    |    |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.5.2 (*)
-|    |    |    |    +--- androidx.savedstate:savedstate-ktx:1.1.0
-|    |    |    |    |    +--- androidx.savedstate:savedstate:1.1.0 (*)
-|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.0 (*)
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.6.0 (*)
-|    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.7.0 (*)
-|    |    |    +--- androidx.collection:collection-ktx:1.1.0
-|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.6.0 (*)
-|    |    |    |    \--- androidx.collection:collection:1.1.0 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.3.1 -> 2.4.0
-|    |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.4.0 (*)
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.0 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.0 (*)
-|    |    |    +--- androidx.savedstate:savedstate-ktx:1.1.0 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
-|    |    +--- androidx.navigation:navigation-runtime:2.4.0-beta02
-|    |    |    +--- androidx.navigation:navigation-common:2.4.0-beta02
-|    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.0 (*)
-|    |    |    |    +--- androidx.savedstate:savedstate:1.0.0 -> 1.1.0 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.4.0 (*)
-|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
-|    |    |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
-|    |    |    |    \--- androidx.collection:collection-ktx:1.1.0 (*)
-|    |    |    +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.0 (*)
-|    |    |    +--- androidx.annotation:annotation-experimental:1.1.0
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
-|    |    +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0-beta01 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
-|    \--- androidx.navigation:navigation-runtime-ktx:2.4.0-beta02
-|         +--- androidx.navigation:navigation-runtime:2.4.0-beta02 (*)
-|         \--- androidx.navigation:navigation-common-ktx:2.4.0-beta02
-|              \--- androidx.navigation:navigation-common:2.4.0-beta02 (*)
++--- androidx.navigation:navigation-fragment-ktx:2.4.0-rc01
+|    +--- androidx.navigation:navigation-fragment:2.4.0-rc01
+|    |    +--- androidx.fragment:fragment-ktx:1.4.0
+|    |    |    +--- androidx.fragment:fragment:1.4.0 (*)
+|    |    |    +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1
+|    |    |    |    +--- androidx.activity:activity:1.3.1 (*)
+|    |    |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
+|    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1
+|    |    |    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.4.0 (*)
+|    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.5.31 (*)
+|    |    |    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.4.1 -> 1.5.2 (*)
+|    |    |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.0
+|    |    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.4.0 (*)
+|    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.5.31 (*)
+|    |    |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.5.2 (*)
+|    |    |    |    +--- androidx.savedstate:savedstate-ktx:1.1.0
+|    |    |    |    |    +--- androidx.savedstate:savedstate:1.1.0 (*)
+|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.5.31 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.5.31 (*)
+|    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.7.0 (*)
+|    |    |    +--- androidx.collection:collection-ktx:1.1.0
+|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.5.31 (*)
+|    |    |    |    \--- androidx.collection:collection:1.1.0 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.3.1 -> 2.4.0
+|    |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.4.0 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.5.31 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.0 (*)
+|    |    |    +--- androidx.savedstate:savedstate-ktx:1.1.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 (*)
+|    |    +--- androidx.navigation:navigation-runtime:2.4.0-rc01
+|    |    |    +--- androidx.navigation:navigation-common:2.4.0-rc01
+|    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 (*)
+|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.0 (*)
+|    |    |    |    +--- androidx.savedstate:savedstate:1.0.0 -> 1.1.0 (*)
+|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.4.0 (*)
+|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
+|    |    |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
+|    |    |    |    \--- androidx.collection:collection-ktx:1.1.0 (*)
+|    |    |    +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.0 (*)
+|    |    |    +--- androidx.annotation:annotation-experimental:1.1.0
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
+|    |    +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0-rc01 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
+|    \--- androidx.navigation:navigation-runtime-ktx:2.4.0-rc01
+|         +--- androidx.navigation:navigation-runtime:2.4.0-rc01 (*)
+|         \--- androidx.navigation:navigation-common-ktx:2.4.0-rc01
+|              \--- androidx.navigation:navigation-common:2.4.0-rc01 (*)
-+--- androidx.navigation:navigation-ui-ktx:2.4.0-beta02
-|    +--- androidx.navigation:navigation-ui:2.4.0-beta02
-|    |    +--- androidx.navigation:navigation-runtime:2.4.0-beta02 (*)
-|    |    +--- androidx.customview:customview:1.1.0 (*)
-|    |    +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
-|    |    +--- com.google.android.material:material:1.4.0-beta01 -> 1.6.0-alpha01 (*)
-|    |    +--- androidx.annotation:annotation-experimental:1.1.0
-|    |    \--- androidx.transition:transition:1.3.0 -> 1.4.1 (*)
-|    \--- androidx.navigation:navigation-runtime-ktx:2.4.0-beta02 (*)
++--- androidx.navigation:navigation-ui-ktx:2.4.0-rc01
+|    +--- androidx.navigation:navigation-ui:2.4.0-rc01
+|    |    +--- androidx.navigation:navigation-runtime:2.4.0-rc01 (*)
+|    |    +--- androidx.customview:customview:1.1.0 (*)
+|    |    +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
+|    |    +--- com.google.android.material:material:1.4.0-beta01 -> 1.6.0-alpha01 (*)
+|    |    +--- androidx.annotation:annotation-experimental:1.1.0
+|    |    \--- androidx.transition:transition:1.3.0 -> 1.4.1 (*)
+|    \--- androidx.navigation:navigation-runtime-ktx:2.4.0-rc01 (*)
 +--- com.github.Automattic:Automattic-Tracks-Android:2.1.0
-|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.6.0 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.5.31 (*)
 |    \--- io.sentry:sentry-android-okhttp:5.0.1
 |         \--- com.squareup.okhttp3:okhttp -> 4.9.0
 |              +--- com.squareup.okio:okio:2.8.0 -> 3.0.0-alpha.9
-|              |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.20 -> 1.6.0
+|              |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.20 -> 1.5.31
-|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.0 (*)
+|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.5.31 (*)
 +--- org.wordpress:fluxc:develop-5baed7c379f856ea624b94853ed6f8bab74e739c
-|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.0 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.5.31 (*)
 |    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.4.10 -> 1.5.31
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 (*)
 |    \--- androidx.room:room-ktx:2.3.0
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.6.0 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.5.31 (*)
 +--- org.wordpress.fluxc.plugins:woocommerce:develop-5baed7c379f856ea624b94853ed6f8bab74e739c
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.0 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.5.31 (*)
 +--- org.wordpress:login:0.10.0
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.6.0 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.5.31 (*)
 +--- com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:v1.3.45
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.11 -> 1.6.0 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.11 -> 1.5.31 (*)
 +--- com.github.wordpress-mobile.WordPress-Aztec-Android:glide-loader:v1.3.45
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.11 -> 1.6.0 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.11 -> 1.5.31 (*)
 +--- project :libs:cardreader
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.0 -> 1.5.31 (*)
 |    \--- com.stripe:stripeterminal:2.5.2
 |         \--- com.stripe:stripeterminal-core:2.5.2
 |              +--- com.stripe:stripeterminal-external:2.5.2
 |              |    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31
-|              |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
+|              |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 (*)
 |              |    \--- com.squareup.moshi:moshi:1.12.0
-|              |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.6.0 (*)
+|              |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.5.31 (*)
 |              +--- com.stripe:stripeterminal-internal-common:2.5.2
 |              |    \--- com.squareup.moshi:moshi-adapters:1.12.0
-|              |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.6.0 (*)
+|              |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.5.31 (*)
 |              +--- io.reactivex.rxjava2:rxkotlin:2.4.0
-|              |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.40 -> 1.6.0 (*)
+|              |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.40 -> 1.5.31 (*)
 |              +--- androidx.lifecycle:lifecycle-livedata-ktx:2.3.1 -> 2.4.0
-|              |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.0 (*)
+|              |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.5.31 (*)
 |              \--- com.squareup.wire:wire-moshi-adapter:4.0.0-alpha.11
 |                   +--- com.squareup.wire:wire-runtime:4.0.0-alpha.11
 |                   |    \--- com.squareup.wire:wire-runtime-jvm:4.0.0-alpha.11
-|                   |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.20 -> 1.6.0
+|                   |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.20 -> 1.5.31
 |                   \--- com.squareup.moshi:moshi-kotlin:1.12.0
-|                        +--- org.jetbrains.kotlin:kotlin-reflect:1.4.31
-|                        |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.6.0 (*)
+|                        +--- org.jetbrains.kotlin:kotlin-reflect:1.4.31 -> 1.5.31
+|                        |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 (*)
-|                        \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.6.0 (*)
+|                        \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.5.31 (*)
 +--- com.automattic:about:0.0.4
 |    +--- androidx.compose.ui:ui:1.0.5 -> 1.1.0-beta04
 |    |    +--- androidx.compose.runtime:runtime-saveable:1.1.0-beta04
 |    |    |    +--- androidx.compose.runtime:runtime:1.1.0-beta04
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
 |    |    +--- androidx.compose.ui:ui-geometry:1.1.0-beta04
 |    |    |    +--- androidx.compose.ui:ui-util:1.1.0-beta04
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
 |    |    +--- androidx.compose.ui:ui-graphics:1.1.0-beta04
 |    |    |    +--- androidx.compose.ui:ui-unit:1.1.0-beta04
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0 -> 1.5.31
 |    |    +--- androidx.compose.ui:ui-text:1.1.0-beta04
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0 -> 1.5.31
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0 -> 1.5.31
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
 |    +--- androidx.compose.ui:ui-tooling:1.0.5
 |    |    +--- androidx.compose.ui:ui-tooling-preview:1.0.5
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 (*)
 |    |    +--- androidx.compose.ui:ui-tooling-data:1.0.5
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 (*)
 |    |    +--- androidx.compose.material:material:1.0.5 -> 1.1.0-beta04
 |    |    |    +--- androidx.compose.animation:animation-core:1.0.0 -> 1.1.0-beta04
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
 |    |    |    +--- androidx.compose.foundation:foundation:1.1.0-beta04
 |    |    |    |    +--- androidx.compose.animation:animation:1.1.0-beta04
 |    |    |    |    |    +--- androidx.compose.foundation:foundation-layout:1.0.0 -> 1.1.0-beta04
-|    |    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0
+|    |    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0 -> 1.5.31
-|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0
+|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0 -> 1.5.31
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0 -> 1.5.31
 |    |    |    +--- androidx.compose.material:material-icons-core:1.1.0-beta04
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
 |    |    |    +--- androidx.compose.material:material-ripple:1.1.0-beta04
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0 -> 1.5.31
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0 -> 1.5.31
 |    |    \--- androidx.activity:activity-compose:1.3.1
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.6.0 (*)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.5.31 (*)
 |    +--- androidx.navigation:navigation-compose:2.4.0-beta02
 |    |    +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.4.0-rc01
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.5.31 (*)
-|    |    +--- androidx.navigation:navigation-runtime-ktx:2.4.0-beta02 (*)
+|    |    +--- androidx.navigation:navigation-runtime-ktx:2.4.0-beta02 -> 2.4.0-rc01 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.0 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 (*)
 |    \--- com.google.android.material:compose-theme-adapter:1.1.1
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.5.31 (*)
 +--- androidx.hilt:hilt-navigation-fragment:1.0.0
-|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.6.0 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.5.31 (*)
 |    +--- androidx.hilt:hilt-navigation:1.0.0
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.6.0 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.5.31 (*)
-|    |    \--- androidx.navigation:navigation-runtime:2.3.2 -> 2.4.0-beta02 (*)
+|    |    \--- androidx.navigation:navigation-runtime:2.3.2 -> 2.4.0-rc01 (*)
-|    \--- androidx.navigation:navigation-fragment-ktx:2.3.2 -> 2.4.0-beta02 (*)
+|    \--- androidx.navigation:navigation-fragment-ktx:2.3.2 -> 2.4.0-rc01 (*)
 +--- com.zendesk:support:5.0.6
 |    +--- com.zendesk:support-providers:5.0.6
 |    |    \--- com.zendesk:core:4.0.6
 |    |         \--- com.zendesk:java-common:2.0.0
-|    |              \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.6.0 (*)
+|    |              \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.5.31 (*)
 |    \--- com.zendesk:guide:1.0.5
 |         \--- com.zendesk:messaging:5.2.3
 |              \--- com.google.android.flexbox:flexbox:3.0.0
-|                   \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.6.0 (*)
+|                   \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.5.31 (*)
 +--- org.wordpress:mediapicker:trunk-00947a9086ecdf2192b0bdc95a22e1647696d0b1
-|    +--- androidx.navigation:navigation-fragment-ktx:2.3.5 -> 2.4.0-beta02 (*)
+|    +--- androidx.navigation:navigation-fragment-ktx:2.3.5 -> 2.4.0-rc01 (*)
 |    \--- com.google.dagger:hilt-android-compiler:2.40.1
 |         +--- com.google.dagger:dagger-compiler:2.40.1
-|         |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.0 (*)
+|         |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.5.31 (*)
 |         |    \--- org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.3.0
-|         |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.0 -> 1.6.0 (*)
+|         |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.0 -> 1.5.31 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.0 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.5.31 (*)
-\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31 (*)
+\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.0 -> 1.5.31 (*)

Please review and act accordingly

hichamboushaba · 2022-03-25T11:12:24Z

Closing in favor of #6093

hichamboushaba added the type: task An internally driven task. label Dec 24, 2021

hichamboushaba added this to the 8.3 milestone Dec 24, 2021

hichamboushaba added 2 commits December 24, 2021 11:24

Bump navigation to 2.4.0-rc01

71f2aec

Remove the navargs workaround

f93b91b

hichamboushaba force-pushed the update-navigation branch from 73d537b to f93b91b Compare December 24, 2021 11:11

hichamboushaba added the status: on hold Currently not prioritized. label Dec 27, 2021

wzieba mentioned this pull request Dec 27, 2021

Plugin DSL wordpress-mobile/WordPress-Android#15314

Merged

3 tasks

Remove non-used test helpers

8d4842a

hichamboushaba force-pushed the update-navigation branch from 925a3cf to 8d4842a Compare January 3, 2022 14:32

jkmassel modified the milestones: 8.3, 8.4 Jan 10, 2022

wzieba mentioned this pull request Jan 14, 2022

[HACK] A new CI step to check if dependencies were changed #5420

Merged

1 task

wzieba and others added 2 commits January 14, 2022 13:26

Merge branch 'trunk' into update-navigation

cd13185

Force all kotlin libraries to use our defined version

c5f3caf

jkmassel modified the milestones: 8.4, 8.5 Jan 25, 2022

jkmassel modified the milestones: 8.5, 8.6 Feb 8, 2022

hichamboushaba removed this from the 8.6 milestone Feb 14, 2022

hichamboushaba mentioned this pull request Feb 21, 2022

Upgrade Gradle to 7.4 & AGP to 7.1.1 #5755

Merged

20 tasks

hichamboushaba mentioned this pull request Mar 24, 2022

Fix build speed issue #6087

Merged

1 task

hichamboushaba closed this Mar 25, 2022

hichamboushaba deleted the update-navigation branch March 25, 2022 11:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update navigation library#5521

Update navigation library#5521
hichamboushaba wants to merge 5 commits intotrunkfrom
update-navigation

hichamboushaba commented Dec 24, 2021 •

edited

Loading

Uh oh!

peril-woocommerce bot commented Dec 24, 2021 •

edited

Loading

Uh oh!

wzieba commented Dec 24, 2021

Uh oh!

hichamboushaba commented Dec 24, 2021

Uh oh!

wzieba commented Dec 24, 2021

Uh oh!

hichamboushaba commented Dec 24, 2021

Uh oh!

wpmobilebot commented Jan 14, 2022

Uh oh!

hichamboushaba commented Mar 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hichamboushaba commented Dec 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

peril-woocommerce bot commented Dec 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wzieba commented Dec 24, 2021

Uh oh!

hichamboushaba commented Dec 24, 2021

Uh oh!

wzieba commented Dec 24, 2021

Uh oh!

hichamboushaba commented Dec 24, 2021

Uh oh!

wpmobilebot commented Jan 14, 2022

The PR caused the following dependency changes:

Uh oh!

hichamboushaba commented Mar 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hichamboushaba commented Dec 24, 2021 •

edited

Loading

peril-woocommerce bot commented Dec 24, 2021 •

edited

Loading