Navigation: remove the NavArgs workaround#6093
Merged
Conversation
1 task
kidinov
approved these changes
Mar 25, 2022
Contributor
kidinov
left a comment
There was a problem hiding this comment.
Thank you for taking care of this. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The beta version of navigation had a bug that prevented restoring custom Parcelables from the saved state, which resulted in using a #5307 to prevent the crash.
Now, that we updated the navigation to 2.4.1 which contains Google's fix for the bug we reported, we can safely remove the workaround.
Testing instructions
Confirm the previous bug is fixed:
RELEASE-NOTES.txtif necessary.