Skip to content

Part 5: Signin M1 - add jetpack support documentation#1147

Merged
nbradbury merged 3 commits intofeature/signin-milestone-1from
amanda/signin-m1-support-link
Jun 13, 2019
Merged

Part 5: Signin M1 - add jetpack support documentation#1147
nbradbury merged 3 commits intofeature/signin-milestone-1from
amanda/signin-m1-support-link

Conversation

@AmandaRiu
Copy link
Copy Markdown
Contributor

@AmandaRiu AmandaRiu commented Jun 13, 2019

This PR partially fixes #1091 by linking the new Jetpack Setup Instructions support document to the appropriate buttons in the new Sign in flow.

There are two ways to open this support document:

  • Jetpack required screen: "View Instructions" button.
  • What is Jetpack dialog: "Learn more" button

To Test

  • Login with a site that does not have jetpack installed.
  • Click "View Instructions" on the jetpack required screen - support page should open.
  • Click "What is Jetpack?" on the jetpack required screen, then click "Learn more" - support page should open.

@AmandaRiu AmandaRiu added this to the 2.1 milestone Jun 13, 2019
@anitaa1990
Copy link
Copy Markdown
Contributor

anitaa1990 commented Jun 13, 2019

@AmandaRiu I tested the functionally and this looks good. But I remember we had a feature branch for the sign in changes. Did you mean to merge this PR with develop instead of that branch? There are some merge conflicts because of this and I'm not sure if that was intentional 😄 .

Also, I think the latest event changes from this PR have not been merged with this branch as well.

@AmandaRiu AmandaRiu changed the base branch from develop to feature/signin-milestone-1 June 13, 2019 15:23
@nbradbury
Copy link
Copy Markdown
Contributor

nbradbury commented Jun 13, 2019

Looks good! :shipit:

@nbradbury nbradbury merged commit 179b2a4 into feature/signin-milestone-1 Jun 13, 2019
@nbradbury nbradbury deleted the amanda/signin-m1-support-link branch June 13, 2019 20:31
@AmandaRiu AmandaRiu mentioned this pull request Jun 14, 2019
Merged
1 task
@designsimply designsimply added feature: login Related to any part of the log in or sign in flow, or authentication. and removed Login labels May 6, 2021
@peril-woocommerce
Copy link
Copy Markdown

peril-woocommerce bot commented May 6, 2021

Fails
🚫

Danger failed to run /app/danger-0.gl00x4fusqt.ts.

Error TypeError

Cannot read property 'diff' of null
TypeError: Cannot read property 'diff' of null
    at checkCommitDiffs (/app/danger-0.gl00x4fusqt.ts:43:49)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

38|         if (git === undefined) {
39|             console.log("About to crash due to an error")
40|             console.log("File:", thisFile)
41|             console.log("Danger Object: ", danger)
42| 
---------------------------------------------------^
43|             if (danger !== undefined) {
44|                 console.log("Danger is no longer defined")
45|             }
46|             else {

Generated by 🚫 dangerJS

@peril-woocommerce
Copy link
Copy Markdown

peril-woocommerce bot commented May 6, 2021

Fails
🚫

Danger failed to run /app/danger-0.3wmlmefd7si.ts.

Error TypeError

Cannot read property 'diff' of null
TypeError: Cannot read property 'diff' of null
    at checkCommitDiffs (/app/danger-0.3wmlmefd7si.ts:43:49)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

38|         if (git === undefined) {
39|             console.log("About to crash due to an error")
40|             console.log("File:", thisFile)
41|             console.log("Danger Object: ", danger)
42| 
---------------------------------------------------^
43|             if (danger !== undefined) {
44|                 console.log("Danger is no longer defined")
45|             }
46|             else {

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbradbury nbradbury Awaiting requested review from nbradbury

@anitaa1990 anitaa1990 Awaiting requested review from anitaa1990

Assignees

No one assigned

Labels

feature: login Related to any part of the log in or sign in flow, or authentication.

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@AmandaRiu @anitaa1990 @nbradbury @designsimply