Part 4: Sign in Milestone 1 Tracks Events#1137
Merged
anitaa1990 merged 9 commits intofeature/signin-milestone-1from Jun 13, 2019
Merged
Part 4: Sign in Milestone 1 Tracks Events#1137anitaa1990 merged 9 commits intofeature/signin-milestone-1from
anitaa1990 merged 9 commits intofeature/signin-milestone-1from
Conversation
added 8 commits
June 4, 2019 17:37
anitaa1990
approved these changes
Jun 13, 2019
Contributor
anitaa1990
left a comment
There was a problem hiding this comment.
@AmandaRiu, everything looks great! LGTM ![]()
Error TypeErrorDangerfileGenerated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #1091 by adding the logic to track events for new sign in milestone 1 features. This includes:
Previous PRs for this feature
Not Included in this PR (coming later):
Data Events
We are using the
FetchConnectedSiteInfoFluxC endpoint temporarily do a pre-check on the url entered inLoginSiteAddressFragment.LOGIN_CONNECTED_SITE_INFO_REQUESTED(url)LOGIN_CONNECTED_SITE_INFO_FAILED(url, error, message)LOGIN_CONNECTED_SITE_INFO_SUCCEEDED(url, exists, hasJetpack, isJetpackActive, isJetpackConnected, isWordPress, isWPCom, jetpackVersion, skipRemoteInstall)View Events
Login Email Screen
A new "Need help finding the email you connected with?" link was added to the login screen where the user enters their email.
LOGIN_BY_EMAIL_HELP_FINDING_CONNECTED_EMAIL_LINK_TAPPEDLogin Jetpack Required Screen
This screen is displayed when the
FetchConnectedSiteInforesult tells us that Jetpack is not connected to this WordPress site.LOGIN_JETPACK_REQUIRED_SCREEN_VIEWEDLOGIN_JETPACK_REQUIRED_VIEW_INSTRUCTIONS_BUTTON_TAPPEDLOGIN_JETPACK_REQUIRED_CONTACT_SUPPORT_BUTTON_TAPPEDLOGIN_JETPACK_REQUIRED_WHAT_IS_JETPACK_LINK_TAPPEDLOGIN_JETPACK_REQUIRED_MENU_HELP_TAPPEDWhat is Jetpack? Dialog
LOGIN_WHAT_IS_JETPACK_HELP_SCREEN_LEARN_MORE_BUTTON_TAPPEDLOGIN_WHAT_IS_JETPACK_HELP_SCREEN_OK_BUTTON_TAPPEDLOGIN_WHAT_IS_JETPACK_HELP_SCREEN_VIEWEDWhat email do I sign in with? Dialog
LOGIN_FIND_CONNECTED_EMAIL_HELP_SCREEN_VIEWEDLOGIN_FIND_CONNECTED_EMAIL_HELP_SCREEN_NEED_MORE_HELP_LINK_TAPPEDLOGIN_FIND_CONNECTED_EMAIL_HELP_SCREEN_OK_BUTTON_TAPPEDSite picker screen & Auto Login
SitePickerActivityhas a lot of responsibilities. When performing a login by url, it will check to make sure the url belongs to the authenticated account and has WooCommerce installed. It's also used as the Site Switcher from the Settings screen so that should be tested as well.SITE_PICKER_AUTO_LOGIN_SUBMITTED(selected_store_id)SITE_PICKER_AUTO_LOGIN_ERROR_NOT_CONNECTED_TO_USER(url, has_connected_stores [true|false])SITE_PICKER_AUTO_LOGIN_ERROR_NOT_WOO_STORE(url, has_connected_stores [true|false])SITE_PICKER_TRY_ANOTHER_ACCOUNT_BUTTON_TAPPEDSITE_PICKER_VIEW_CONNECTED_STORES_BUTTON_TAPPEDSITE_PICKER_HELP_FINDING_CONNECTED_EMAIL_LINK_TAPPED