Skip to content

Part 2: What is Jetpack Dialog#1125

Merged
anitaa1990 merged 6 commits intofeature/signin-milestone-1from
amanda/signin-whatis-jetpack
Jun 5, 2019
Merged

Part 2: What is Jetpack Dialog#1125
anitaa1990 merged 6 commits intofeature/signin-milestone-1from
amanda/signin-whatis-jetpack

Conversation

@AmandaRiu
Copy link
Copy Markdown
Contributor

This PR is part 2 of a series of PRs for the new Sign in milestone 1 feature as described in #1091. This PR #1121 was part 1.

This PR adds the following functionality:

  • A new LoginWhatIsJetpackDialogFragment has been added to describe Jetpack to the end user.
  • This new dialog is wired up to the "What is Jetpack?" button on the LoginJetpackRequiredFragment.
  • Portrait and landscape layouts for the new dialog

The following has been stubbed out:

  • The LEARN MORE and VIEW INSTRUCTIONS buttons will eventually point to the same place, a support document outlining detailed instructions on how to install the plugin. Once I have this URL, I will wire it in.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@AmandaRiu AmandaRiu self-assigned this Jun 4, 2019
@AmandaRiu AmandaRiu added this to the 2.1 milestone Jun 4, 2019
@AmandaRiu AmandaRiu requested review from anitaa1990 and nbradbury June 4, 2019 22:36
@AmandaRiu AmandaRiu marked this pull request as ready for review June 4, 2019 22:37
@anitaa1990 anitaa1990 self-assigned this Jun 5, 2019
Copy link
Copy Markdown
Contributor

@anitaa1990 anitaa1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 👍 LGTM :shipit:

@anitaa1990 anitaa1990 merged commit d450e24 into feature/signin-milestone-1 Jun 5, 2019
@anitaa1990 anitaa1990 deleted the amanda/signin-whatis-jetpack branch June 5, 2019 03:30
@designsimply designsimply added feature: login Related to any part of the log in or sign in flow, or authentication. and removed Login labels May 6, 2021
@peril-woocommerce
Copy link
Copy Markdown

peril-woocommerce bot commented May 6, 2021

Fails
🚫

Danger failed to run /app/danger-0.ghym2ocg10s.ts.

🚫

Danger failed to run /app/danger-0.1al3dadt1ei.ts.

Error TypeError

Cannot read property 'added' of null
TypeError: Cannot read property 'added' of null
    at Object.exports.default (/app/danger-0.ghym2ocg10s.ts:16:44)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

11|         warn("The PlayStoreStrings.po file must be updated any time changes are made to release notes");
12|     }
13| 
14|     // If changes were made to the strings, make sure they follow our guidelines
15|     const modifiedStrings = modifiedFiles.filter((path: string) => path.endsWith('values/strings.xml'))
----------------------------------------------^
16| 
17|     for (let file of modifiedStrings) {        
18|         const stringDiffs = await danger.git.diffForFile(file)
19| 

Error TypeError

Cannot read property 'diff' of null
TypeError: Cannot read property 'diff' of null
    at checkCommitDiffs (/app/danger-0.1al3dadt1ei.ts:43:49)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

38|         if (git === undefined) {
39|             console.log("About to crash due to an error")
40|             console.log("File:", thisFile)
41|             console.log("Danger Object: ", danger)
42| 
---------------------------------------------------^
43|             if (danger !== undefined) {
44|                 console.log("Danger is no longer defined")
45|             }
46|             else {

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: login Related to any part of the log in or sign in flow, or authentication.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants