Part 2: What is Jetpack Dialog#1125
Merged
anitaa1990 merged 6 commits intofeature/signin-milestone-1from Jun 5, 2019
Merged
Conversation
added 5 commits
June 4, 2019 11:03
The new asset has a transparent background so I can set the background to stretch as needed while preserving aspect ratio of this image.
anitaa1990
approved these changes
Jun 5, 2019
Contributor
anitaa1990
left a comment
There was a problem hiding this comment.
This looks great! 👍 LGTM ![]()
This was referenced Jun 8, 2019
Error TypeErrorDangerfileError TypeErrorDangerfileGenerated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part 2 of a series of PRs for the new Sign in milestone 1 feature as described in #1091. This PR #1121 was part 1.
This PR adds the following functionality:
LoginWhatIsJetpackDialogFragmenthas been added to describe Jetpack to the end user.LoginJetpackRequiredFragment.The following has been stubbed out:
Update release notes:
RELEASE-NOTES.txt.