ML_KEM IDs backward compat #8827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
retest this please |
3228a1e to
852a937
Compare
Contributor
Author
|
retest this please |
kp-max-li
added a commit
to expressvpn/lightway-core
that referenced
this pull request
Jun 5, 2025
From 5.7.6 to 5.8.0, WolfSSL has updated the codepoints of the postquantum curves according to OQS's specification. open-quantum-safe/oqs-provider@8abfecd#diff-ad6b78182015150daf78fa86f78db241b4489a2137c559c95da15cc62c7c1a7bL89 However, the codepoints are incompatible between versions at or before 5.7.6 and versions at or after 5.8.0. Hence, this patch is added to make it backward compatible. The patch is retrieved from wolfSSL/wolfssl#8827 Behaviour: If version <= 5.7.6 is connected to version >= 5.8.0, old codepoint is used. If version >= 5.8.0 is connected to version >= 5.8.0, new codepoint is used.
8 tasks
Allow backward compatibilitly of Hybrid ML_KEM codepoints in TLS with version before wolfSSL 5.8.0. When WOLFSSL_ML_KEM_USE_OLD_IDS is defined, it will accept the old codepoints for P256 with ML-KEM-512, P384 with ML-KEM-768, P521 with ML-KEM-10124. (Others combinations were not know pre 5.8.0.) Both old client with new server and new client with new server work with old codepoints.
852a937 to
7eca4fb
Compare
kp-max-li
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Jun 6, 2025
From 5.7.6 to 5.8.0, WolfSSL has updated the codepoints of the postquantum curves according to OQS's specification. open-quantum-safe/oqs-provider@8abfecd#diff-ad6b78182015150daf78fa86f78db241b4489a2137c559c95da15cc62c7c1a7bL89 However, the codepoints are incompatible between versions at or before 5.7.6 and versions at or after 5.8.0. Hence, this patch is added to make it backward compatible. The patch is retrieved from wolfSSL/wolfssl#8827 Behaviour: If version <= 5.7.6 is connected to version >= 5.8.0, old codepoint is used. If version >= 5.8.0 is connected to version >= 5.8.0, new codepoint is used.
kp-max-li
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Jun 6, 2025
From 5.7.6 to 5.8.0, WolfSSL has updated the codepoints of the postquantum curves according to OQS's specification. open-quantum-safe/oqs-provider@8abfecd#diff-ad6b78182015150daf78fa86f78db241b4489a2137c559c95da15cc62c7c1a7bL89 However, the codepoints are incompatible between versions at or before 5.7.6 and versions at or after 5.8.0. Hence, this patch is added to make it backward compatible. The patch is retrieved from wolfSSL/wolfssl#8827 Behaviour: If version <= 5.7.6 is connected to version >= 5.8.0, old codepoint is used. If version >= 5.8.0 is connected to version >= 5.8.0, new codepoint is used.
kp-max-li
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Jun 6, 2025
From 5.7.6 to 5.8.0, WolfSSL has updated the codepoints of the postquantum curves according to OQS's specification. open-quantum-safe/oqs-provider@8abfecd#diff-ad6b78182015150daf78fa86f78db241b4489a2137c559c95da15cc62c7c1a7bL89 However, the codepoints are incompatible between versions at or before 5.7.6 and versions at or after 5.8.0. Hence, this patch is added to make it backward compatible. The patch is retrieved from wolfSSL/wolfssl#8827 Behaviour: If version <= 5.7.6 is connected to version >= 5.8.0, old codepoint is used. If version >= 5.8.0 is connected to version >= 5.8.0, new codepoint is used.
kp-max-li
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Jun 6, 2025
From 5.7.6 to 5.8.0, WolfSSL has updated the codepoints of the postquantum curves according to OQS's specification. open-quantum-safe/oqs-provider@8abfecd#diff-ad6b78182015150daf78fa86f78db241b4489a2137c559c95da15cc62c7c1a7bL89 However, the codepoints are incompatible between versions at or before 5.7.6 and versions at or after 5.8.0. Hence, this patch is added to make it backward compatible. The patch is retrieved from wolfSSL/wolfssl#8827 Behaviour: If version <= 5.7.6 is connected to version >= 5.8.0, old codepoint is used. If version >= 5.8.0 is connected to version >= 5.8.0, new codepoint is used.
JacobBarthelmeh
approved these changes
Jun 6, 2025
kp-thomas-yau
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Nov 3, 2025
…2` release Related PR: - wolfSSL/wolfssl#8833 - wolfSSL/wolfssl#8827
kp-thomas-yau
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Nov 5, 2025
…2` release Related PR: - wolfSSL/wolfssl#8833 - wolfSSL/wolfssl#8827
kp-thomas-yau
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Nov 7, 2025
…2` release Related PR: - wolfSSL/wolfssl#8833 - wolfSSL/wolfssl#8827
kp-thomas-yau
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Nov 11, 2025
…2` release Related PR: - wolfSSL/wolfssl#8833 - wolfSSL/wolfssl#8827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow backward compatibilitly of Hybrid ML_KEM codepoints in TLS with version before wolfSSL 5.8.0.
When WOLFSSL_ML_KEM_USE_OLD_IDS is defined, it will accept the old codepoints for P256 with ML-KEM-512, P384 with ML-KEM-768, P521 with ML-KEM-10124. (Others combinations were not know pre 5.8.0.) Both old client with new server and new client with new server work with old codepoints.
Fixes zd#19967
Testing
Checkout 5.7.6::
./configure --disable-shared --enable-mlkem=all
Checkout master:
./configure --disable-shared --enable-mlkem=yes,kyber,ml-kem
./examples/client/client -v 4 --pqc P521_ML_KEM_1024
./examples/client/server -v 4 --pqc P521_ML_KEM_1024
All combinations of new/old client/server.
Checklist