NTP validation, and rejecting malformed responses (related to #3515) #3536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* purge old (not yet processes) NTP responses * validate server responses before updating WLED time * purge receive buffer when package is rejected (avoids mem leak on esp32)
when NTP got enabled via UI, WLED would wait up to 12 hours before issuing the first NTP request.
1 task
blazoncek
approved these changes
Nov 20, 2023
Contributor
blazoncek
left a comment
There was a problem hiding this comment.
Apart from some indentation it looks ok to me.
softhack007
added a commit
to MoonModules/WLED-MM
that referenced
this pull request
Nov 22, 2023
NTP validation, and rejecting malformed responses (related to wled#3515)
softhack007
added a commit
to MoonModules/WLED-MM
that referenced
this pull request
Nov 22, 2023
NTP validation, and rejecting malformed responses (related to wled#3515)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate NTP responses (fixes #3515)
@Aircoookie, @blazoncek: Please quickly check this change in your environment before merging into 0_14_1.