Skip to content

Add LDR sensor dusk/dawn preset control Usermod #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blazoncek merged 1 commit into from
Nov 2, 2023
Merged

Add LDR sensor dusk/dawn preset control Usermod #3490

blazoncek merged 1 commit into from
Nov 2, 2023

Conversation

@JeffWDH
Copy link

@JeffWDH JeffWDH commented Oct 28, 2023

This usermod will obtain readings from a Light Dependent Resistor (LDR) and will turn on/off specific presets based on those readings. This is useful for exterior lighting situations where you want the lights to only be on when it is dark out.

Tested on an ESP32 (HUZZAH32) with a generic LDR.

@blazoncek blazoncek changed the base branch from main to 0_14_1 November 1, 2023 09:37
@blazoncek
Copy link
Contributor

blazoncek commented Nov 1, 2023

It would be great if you could also update const.h and usermod_list.cpp to allow for simpler compile (compiler -D option).

@JeffWDH JeffWDH force-pushed the main branch 3 times, most recently from 2646444 to 28b8262 Compare November 1, 2023 12:25
@JeffWDH
Copy link
Author

JeffWDH commented Nov 1, 2023

It would be great if you could also update const.h and usermod_list.cpp to allow for simpler compile (compiler -D option).

I have made the requested changes.

blazoncek
blazoncek suggested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@blazoncek blazoncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes to platformio.ini, otherwise the PR is fine.

@JeffWDH JeffWDH force-pushed the main branch 4 times, most recently from c29e8e9 to 34a5dca Compare November 2, 2023 15:06
@JeffWDH JeffWDH requested a review from blazoncek November 2, 2023 15:24
@blazoncek
Copy link
Contributor

blazoncek commented Nov 2, 2023

Please do not force push changes next time.

@JeffWDH
Copy link
Author

JeffWDH commented Nov 2, 2023 •
edited
Loading

Understood. Other projects I've contributed to specifically ask for all changes to be contained within a single commit, I'll try to remember for next time.

@blazoncek
Copy link
Contributor

blazoncek commented Nov 2, 2023

Understood. Other projects I've contributed to specifically ask for all changes to be contained within a single commit, I'll try to remember for next time.

We do have such guidelines as well but they are not strict rules, especially if changes are requested.
It makes reviewing code easier if commits are clear. But you can always branch, squash merge and make a new PR if that may be an issue.

@blazoncek blazoncek merged commit 1543862 into wled:0_14_1 Nov 2, 2023
softhack007 pushed a commit to MoonModules/WLED-MM that referenced this pull request Nov 11, 2023
@blazoncek @softhack007
Merge pull request wled#3490 from JeffWDH/main
86a8a30 
Add LDR sensor dusk/dawn preset control Usermod
softhack007 added a commit that referenced this pull request Dec 15, 2023
@softhack007
LDR_Dusk_Dawn: use pinManager, check ldrPin before use (quick-fix for #…
da488f7 
…3490)
softhack007 added a commit to MoonModules/WLED-MM that referenced this pull request Dec 15, 2023
@softhack007
LDR_Dusk_Dawn: use pinManager, check ldrPin before use (quick-fix for w…
52ceabb 
…led#3490)
zanhecht pushed a commit to zanhecht/WLED that referenced this pull request Dec 27, 2023
@softhack007 @zanhecht
LDR_Dusk_Dawn: use pinManager, check ldrPin before use (quick-fix for w…
2a4f712 
…led#3490)
@blazoncek blazoncek mentioned this pull request Jan 18, 2024
Open
1 task
JPZV pushed a commit to JPZV/WLED that referenced this pull request Jan 18, 2024
@softhack007 @JPZV
LDR_Dusk_Dawn: use pinManager, check ldrPin before use (quick-fix for w…
613e128 
…led#3490)
DedeHai pushed a commit to DedeHai/WLED that referenced this pull request Jan 27, 2024
@softhack007 @DedeHai
LDR_Dusk_Dawn: use pinManager, check ldrPin before use (quick-fix for w…
a263c4c 
…led#3490)
@blazoncek blazoncek mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blazoncek blazoncek blazoncek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JeffWDH @blazoncek @softhack007