ESP8266 core 4.1.0, ESP32 core 5.2.0 (S2,S3,C3) #3144

blazoncek · 2023-03-21T16:28:55Z

Also updates NeoPixelBus to 2.7.3 (adding UCS890x support)

NeoPixelBus 2.7.3 (adding UCS890x support)

platformio.ini

softhack007 · 2023-03-21T17:33:02Z

Hi,
platform = espressif32@5.2.0 seems to be a good choice for the new MCUs, works well on the devices I have.
maybe also add platform_packages = for the new MCUs, so the 8266 packages from [common] are not used on esp32.

As i said in my other comment, -Dregister= is absolutely dangerous, because it also affects inline assembler (macro = textual replacement) and it definitely breaks arduino core on ESP32-C3.

Will do a more detailed review later.

blazoncek · 2023-03-21T19:05:06Z

@softhack007 by all means you are welcome to contribute. 😄

I do not know how platform_packages affects the build process (it didn't appear to do anything on ESP32 related builds) but the change was needed for ESP8266 to allow newer C++ compiler for it.

- corrected some broken references - added `platform_package =` --> use default packages - renamed env:esp32c3 to env:esp32c3dev to avoid confusion - added lolin_s2_mini to CI builds

so it cannot destroy builds for ESP32 devices

softhack007 · 2023-03-21T23:07:08Z

PS: You're right, these massive warnings about "register" from the fastled lib are absolutely annoying. I've move the -Dregister= override into the 8266 section - please feel free to un-comment it, in case you get working binaries on 8266 (could not check that tonight).

experimental ESP32 buildenv using ESP-IDF V4.4.x / arduino-esp32 v2.0.5 Warning: this build environment is not stable!!

blazoncek · 2023-03-22T07:06:59Z

platformio.ini

  -D DECODE_SAMSUNG=true
  -D DECODE_LG=true
-  ;-Dregister= # remove warnings in C++17 due to use of deprecated register keyword by the FastLED library
+  ;-Dregister= # remove warnings in C++17 due to use of deprecated register keyword by the FastLED library ;; warning: this breaks framework code on ESP32-C3 and ESP32-S2


Enabling this did not break S2 or C3 compiles for me.

I saw problems in platform 5.1.1, maybe espressif changed something in 5.2.0.

The build warnings on -C3 looked like this with "register" override enabled

/.platformio/packages/framework-arduinoespressif32/tools/sdk/esp32c3/include/riscv/include/riscv/semihosting.h:75:19: warning: ignoring asm-specifier for non-static local variable 'a0' register long a0 asm ("a0") = id; ^~ .platformio/packages/framework-arduinoespressif32/tools/sdk/esp32c3/include/riscv/include/riscv/semihosting.h:76:19: warning: ignoring asm-specifier for non-static local variable 'a1' register long a1 asm ("a1") = (long) data; ^~

see https://gcc.gnu.org/onlinedocs/gcc/Local-Register-Variables.html

platformio.ini

softhack007 · 2023-03-22T08:15:25Z

Any idea why the github PlatformIO CI build still fails for nodemcuv2 ? It's working on my local PC.

error msg from github CI build:

Compiling .pio/build/nodemcuv2/libcde/FastLED/bitswap.cpp.o 
xtensa-lx106-elf-g++: error: unrecognized command line option '-std=gnu++17' 
 [.pio/build/nodemcuv2/libcde/FastLED/FastLED.cpp.o] Error 1 
xtensa-lx106-elf-g++: error: unrecognized command line option '-std=gnu++17' 
[.pio/build/nodemcuv2/libcde/FastLED/bitswap.cpp.o] Error 1

blazoncek · 2023-03-27T12:57:05Z

@Aircoookie @softhack007 do we merge these changes?
FYI: My 8266, S2 and C3 are working without issues.

I do not know why GH actions are failing. It compiles without issues on my mac.

softhack007 · 2023-03-27T13:41:42Z

@Aircoookie @softhack007 do we merge these changes? FYI: My 8266, S2 and C3 are working without issues.

I do not know why GH actions are failing. It compiles without issues on my mac.

Same here on my Windows - compiles without any complains. 👍 OK to merge from my side.

I'm wondering if we should make these changes before merging:

add -Wno-attributes to standard build flags, because it will silence any NeoPixelBus warnings for 'maybe_unused'
Move -DARDUINO_USB_MSC_ON_BOOT=0 -DARDUINO_USB_DFU_ON_BOOT=0 to the global sections. I don't see any meaningful use for MSC or DFU with WLED. So the only flag that remains for user envs is to set -DARDUINO_USB_CDC_ON_BOOT={0,1} accordingly for debugging.

What do you think?

(explicit toolchain version)

Aircoookie · 2023-03-28T21:20:11Z

Seems like the GH actions machine uses a different xtensa toolchain as default than our local build environments. Explicitely setting the latest seems to take care of it. Approving from my side now👍

@softhack007 I would agree with your proposed changes too. If you'd like, you can add them and merge.

* -Wno-attributes added to common flags * USB_MSC and USB_DFU flags moved to common board sections (does not make sense with WLED to ernable these)

@andyshinn

based on proposal from in PR #2951 by @andyshinn. 2MB does not allow to have an OTA partition, so this feature is disabled.

* esp8266 core 4.1.0 * esp32 "V4" core 5.2.0 * neopixelbus 2.7.5 * use NeoPixelBusLg * Make SPI bus speed user configurable * adjust MM buildEnv to match upstream wled#3144 wled#3173

ESP8266 core 4.1.0, ESP32 core 5.2.0 (S2,S3,C3)

4cd026d

NeoPixelBus 2.7.3 (adding UCS890x support)

blazoncek requested review from Aircoookie and softhack007 March 21, 2023 16:29

softhack007 reviewed Mar 21, 2023

View reviewed changes

platformio.ini Outdated Show resolved Hide resolved

Remove "register" override

0cc719a

softhack007 added 3 commits March 21, 2023 23:15

buildenv improvements for -S3/-S2/-C3

9b90ff1

- corrected some broken references - added `platform_package =` --> use default packages - renamed env:esp32c3 to env:esp32c3dev to avoid confusion - added lolin_s2_mini to CI builds

minor cleanup

bf789ca

moved register override into 8266 section,

646cf44

so it cannot destroy builds for ESP32 devices

experimental esp32 buildenv with platform = espressif32@5.2.0

890aa6f

experimental ESP32 buildenv using ESP-IDF V4.4.x / arduino-esp32 v2.0.5 Warning: this build environment is not stable!!

blazoncek commented Mar 22, 2023

View reviewed changes

platformio.ini Show resolved Hide resolved

blazoncek commented Mar 22, 2023

View reviewed changes

platformio.ini Show resolved Hide resolved

Merge branch 'main' into esp8266-core

7dd3d2b

blazoncek linked an issue Mar 27, 2023 that may be closed by this pull request

lolin_c3_mini board support #2934

Closed

blazoncek mentioned this pull request Mar 28, 2023

support the ESP32-C3-12F module from AI-Thinker and associated boards #2951

Closed

Aircoookie mentioned this pull request Mar 28, 2023

Bump ESP8266 and ESP32 variants core libraries #3151

Merged

Attempt fixing GitHub actions ESP8266 build (#3151)

3968a8e

(explicit toolchain version)

Aircoookie approved these changes Mar 28, 2023

View reviewed changes

softhack007 added 2 commits March 30, 2023 00:03

small re-organization of build flags

a7a6f4c

* -Wno-attributes added to common flags * USB_MSC and USB_DFU flags moved to common board sections (does not make sense with WLED to ernable these)

build env for -C3 with only 2MB flash

54eb42d

based on proposal from in PR #2951 by @andyshinn. 2MB does not allow to have an OTA partition, so this feature is disabled.

softhack007 merged commit 51f38e0 into main Mar 29, 2023

softhack007 deleted the esp8266-core branch March 29, 2023 22:30

Uh oh!

ESP8266 core 4.1.0, ESP32 core 5.2.0 (S2,S3,C3) #3144

ESP8266 core 4.1.0, ESP32 core 5.2.0 (S2,S3,C3) #3144

Uh oh!

Conversation

blazoncek commented Mar 21, 2023

Uh oh!

Uh oh!

softhack007 commented Mar 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazoncek commented Mar 21, 2023

Uh oh!

softhack007 commented Mar 21, 2023

Uh oh!

blazoncek Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

softhack007 Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

softhack007 Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

softhack007 commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazoncek commented Mar 27, 2023

Uh oh!

softhack007 commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aircoookie commented Mar 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

softhack007 commented Mar 21, 2023 •

edited

Loading

softhack007 Mar 22, 2023 •

edited

Loading

softhack007 commented Mar 22, 2023 •

edited

Loading

softhack007 commented Mar 27, 2023 •

edited

Loading