🦋 Changeset detected

Latest commit: 27141e2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

✅ Deploy Preview for astro-starlight ready!

Name	Link
🔨 Latest commit	69e7925
🔍 Latest deploy log	https://app.netlify.com/sites/astro-starlight/deploys/6545db17013d02000804fb8e
😎 Deploy Preview	https://deploy-preview-517--astro-starlight.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sorry, I deleted the branch by mistake and caused #476 to be closed.

@delucis I have some questions, I don't know how to get the current language.

@delucis Hi Chris, Can we keep pushing this PR?

Hey @liruifengv — so sorry I haven’t had time to look at this yet. Promise I’ll get to this ASAP. Thank you again for pushing this — super helpful 💜

Hey @liruifengv! Sorry to take so long to get back on this one, but I think we’re finally ready to try to do this. In #1003 I made it possible for plugins like the asides one to more easily access the same translations system as other Starlight code.

I’ve updated this branch and you should now find useTranslations in packages/starlight/index.ts. You can pass this to the asides plugin and then in each locale do:

const t = useTranslations(locale);
const label = t('aside.note'); // or tip, danger etc.

Are you still interested on working on this? Let me know if not and I’ll take a look at cleaning up your work. Thanks again for your patience on this.

By the way, all the checks are failing because the aside translations are missing in languages added since you started this PR. Let me know if you need help tracking down the missing translations.

Hey @liruifengv! Sorry to take so long to get back on this one, but I think we’re finally ready to try to do this. In #1003 I made it possible for plugins like the asides one to more easily access the same translations system as other Starlight code.

I’ve updated this branch and you should now find useTranslations in packages/starlight/index.ts. You can pass this to the asides plugin and then in each locale do:

const t = useTranslations(locale);
const label = t('aside.note'); // or tip, danger etc.

Are you still interested on working on this? Let me know if not and I’ll take a look at cleaning up your work. Thanks again for your patience on this.

By the way, all the checks are failing because the aside translations are missing in languages added since you started this PR. Let me know if you need help tracking down the missing translations.

I'll take a look.

Thank you!

1. Please note that some of the language was used the original English.
2. I changed getting-started in this PR. this will cause the translation status to be reset. Maybe it shouldn't be included in this PR

1. Please note that some of the language was used the original English.

I think this is ok as ALL languages currently get the English version by default anyway. My plan is to ask for help from the community to update these as soon as we merge.

2. I changed getting-started in this PR. this will cause the translation status to be reset. Maybe it shouldn't be included in this PR

Ah, good catch! Thank you for flagging this. Yes, might be a good idea to remove that change and make it when updating the rest of the page.

1. Please note that some of the language was used the original English.

I think this is ok as ALL languages currently get the English version by default anyway. My plan is to ask for help from the community to update these as soon as we merge.

2. I changed getting-started in this PR. this will cause the translation status to be reset. Maybe it shouldn't be included in this PR

Ah, good catch! Thank you for flagging this. Yes, might be a good idea to remove that change and make it when updating the rest of the page.

Done.