Improve styling of sidebar entries that wrap#419
Improve styling of sidebar entries that wrap#419delucis merged 7 commits intowithastro:mainfrom lorenzolewis:feat/fix-sidebar-wrap-css
Conversation
Signed-off-by: Lorenzo Lewis <lorenzo_lewis@icloud.com>
Signed-off-by: Lorenzo Lewis <lorenzo_lewis@icloud.com>
🦋 Changeset detectedLatest commit: 2668218 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
delucis
left a comment
There was a problem hiding this comment.
Thanks for this @lorenzolewis! I’ve noticed this issue before. I actually think the issue could be better addressed by a narrower line height? That would mean the wrapped lines nestle closer together and form a single visual unit more clearly. Been meaning to tackle that.
I think the requirement would be:
- narrower line-height
- a little extra vertical padding so that the current appearance for single-line links is preserved.
|
Sure, I can get behind that. I'll play around with it a bit to dial it in and update |
Signed-off-by: Lorenzo Lewis <lorenzo_lewis@icloud.com>
@delucis here's those changes, feel free to dial them as you see fit. I tried to keep the overall vertical height of an item as close as possible. |
delucis
left a comment
There was a problem hiding this comment.
That was quick! Looks fantastic, thank you @lorenzolewis. One stylistic nit but that’s all I got.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
What kind of changes does this PR include?
Description
If a sidebar entry wraps to a new line then it can be difficult to distinguish that entry from the ones above/below it. This puts in a fix to visually indent any subsequent lines.
Before:
After:
