Skip to content

feat(content): add Starlight Rose Pine#3736

Merged
HiDeoo merged 3 commits intowithastro:mainfrom
trueberryless:content/starlight-rose-pine
Mar 4, 2026
Merged

feat(content): add Starlight Rose Pine#3736
HiDeoo merged 3 commits intowithastro:mainfrom
trueberryless:content/starlight-rose-pine

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

@trueberryless trueberryless commented Mar 2, 2026

Description

This PR adds a new theme to the theme catalog for the Rose Pine soho vibes.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 2, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: f502ce7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 2, 2026 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit f502ce7
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/69a7f63d36ffe40008ae365b
😎 Deploy Preview https://deploy-preview-3736--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the 📚 docs Documentation website changes label Mar 2, 2026
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Mar 2, 2026 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en resources/themes.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

delucis
delucis reviewed Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trueberryless! Looks nice 💅

One note: looks like the badges text contrast is not accessible (at least in light mode when I tested). Might be good to increase the contrast there if you can!

@trueberryless
Copy link
Copy Markdown
Contributor Author

trueberryless commented Mar 2, 2026

Thanks for the feedback. I'm gonna fix both suggestions in the theme first and apply the changes here then 👍

@trueberryless @delucis
Update docs/src/content/docs/resources/themes.mdx
0af61de 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@trueberryless
Copy link
Copy Markdown
Contributor Author

trueberryless commented Mar 3, 2026

Thanks again for the suggestions, both are fixed now 👍

HiDeoo
HiDeoo approved these changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initial review and the follow-up, looks great to me now.

Tiny feedback, not sure if on purpose or not, but for sidebar links with a badge, when it's the current page, the badge kinda blends in with the highlighted background making it less obvious that it's a badge.

Image

@HiDeoo HiDeoo merged commit edb44bf into withastro:main Mar 4, 2026
16 checks passed
@trueberryless trueberryless deleted the content/starlight-rose-pine branch March 4, 2026 09:14
@trueberryless
Copy link
Copy Markdown
Contributor Author

trueberryless commented Mar 4, 2026 •
edited
Loading

Tiny feedback, not sure if on purpose or not, but for sidebar links with a badge, when it's the current page, the badge kinda blends in with the highlighted background making it less obvious that it's a badge.

Image

Thanks HiDeoo!

This was known to me and made deliberately. I'll see what the general user feedback is for this design choice and update the theme accordingly 👍

ArmandPhilippot added a commit to ArmandPhilippot/starlight that referenced this pull request Mar 5, 2026
@ArmandPhilippot
i18n(fr): update resources/themes.mdx
cc18604 
See withastro#3736
@ArmandPhilippot ArmandPhilippot mentioned this pull request Mar 5, 2026
Merged
@jsparkdev jsparkdev mentioned this pull request Mar 25, 2026
Merged
deining added a commit to deining/starlight that referenced this pull request Apr 6, 2026
@deining
i18n(de): update themes.mdx (PR withastro#3736)
0971914
@deining deining mentioned this pull request Apr 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis left review comments

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees

No one assigned

Labels

📚 docs Documentation website changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trueberryless @astrobot-houston @delucis @HiDeoo