Skip to content

Ignore <script> elements when processing <Steps>#3726

Merged
delucis merged 2 commits intomainfrom
chris/fix-3712
Feb 25, 2026
Merged

Ignore <script> elements when processing <Steps>#3726
delucis merged 2 commits intomainfrom
chris/fix-3712

Conversation

@delucis
Copy link
Copy Markdown
Member

@delucis delucis commented Feb 25, 2026

Description

@delucis delucis added the 🌟 patch Change that triggers a patch release label Feb 25, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 25, 2026 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit b7c730d
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/699ee2f96d02470008a18472
😎 Deploy Preview https://deploy-preview-3726--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 25, 2026

🦋 Changeset detected

Latest commit: b7c730d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Feb 25, 2026
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Feb 25, 2026

size-limit report 📦

Path Size
/index.html 7.29 KB (0%)
/_astro/*.js 25.87 KB (0%)
/_astro/*.css 14.3 KB (0%)

HiDeoo
HiDeoo approved these changes Feb 25, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 🙌

A bit concerned about the potential implications, not of the workaround specifically but more of the general issue, e.g. with some CSS selectors, but looking at the triage bot output, this seems off so this would probably be a tricky issue to fix that would take a bit of time, so might as well just go with the workaround for now.

@delucis
Copy link
Copy Markdown
Member Author

delucis commented Feb 25, 2026

Yes, agreed, I think the regression has the potential to cause annoying issues for people. Luckily in this specific case it’s not too bad as the <script> is just one more element in the flow of Markdown content, so seems less likely to be hit by issues with sibling selectors etc. (To be fair, this was also the case before as we saw with :last-child and stuff in our styles getting messed up by the directly rendered <script> change — but at least those were predictable and contained within a component, whereas as this one causes nasty surprises for parent components.)

Thanks for the review!

@delucis delucis merged commit 8a09b60 into main Feb 25, 2026
18 checks passed
@delucis delucis deleted the chris/fix-3712 branch February 25, 2026 13:24
@astrobot-houston astrobot-houston mentioned this pull request Feb 25, 2026
Merged
@delucis delucis mentioned this pull request Mar 5, 2026
Closed
dadezzz pushed a commit to dadezzz/ice-notes that referenced this pull request Mar 9, 2026
@dadezzz
fix(deps): update dependency @astrojs/starlight to v0.37.7 (#474)
e08c349 
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@astrojs/starlight](https://starlight.astro.build) ([source](https://github.com/withastro/starlight/tree/HEAD/packages/starlight)) | [`0.37.6` → `0.37.7`](https://renovatebot.com/diffs/npm/@astrojs%2fstarlight/0.37.6/0.37.7) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@astrojs%2fstarlight/0.37.7?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@astrojs%2fstarlight/0.37.6/0.37.7?slim=true) |

---

### Release Notes

<details>
<summary>withastro/starlight (@&#8203;astrojs/starlight)</summary>

### [`v0.37.7`](https://github.com/withastro/starlight/blob/HEAD/packages/starlight/CHANGELOG.md#0377)

[Compare Source](https://github.com/withastro/starlight/compare/@astrojs/starlight@0.37.6...@astrojs/starlight@0.37.7)

##### Patch Changes

- [#&#8203;3726](withastro/starlight#3726) [`8a09b60`](withastro/starlight@8a09b60) Thanks [@&#8203;delucis](https://github.com/delucis)! - Fixes an issue using components containing scripts inside Starlight’s steps component in versions of Astro >= 5.16.9

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My41OS41IiwidXBkYXRlZEluVmVyIjoiNDMuNTkuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: Renovate Bot <renovate@zarantonello.dev>
Co-committed-by: Renovate Bot <renovate@zarantonello.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees

No one assigned

Labels

🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using {% steps %} in Mark Doc with {% tabs %}

3 participants

@delucis @astrobot-houston @HiDeoo