Skip to content

i18n(ko-KR): update Korean UI strings#3168

Merged
delucis merged 6 commits intowithastro:mainfrom
jsparkdev:ko
May 2, 2025
Merged

i18n(ko-KR): update Korean UI strings#3168
delucis merged 6 commits intowithastro:mainfrom
jsparkdev:ko

Conversation

@jsparkdev
Copy link
Copy Markdown
Member

Description

update Korean UI strings (and 404.md, sidebar)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: e2b2979

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels May 2, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented May 2, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit e2b2979
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6814c9253e9b3b00083d4897
😎 Deploy Preview https://deploy-preview-3168--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 2, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ko 404.md Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

HiDeoo
HiDeoo previously requested changes May 2, 2025
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a non-native speaker reviewing using the Docs Translation Review Checklist, the changes look great to me 🌟

Considering packages/starlight/translations/ko.json is updated, which is a file shipped with Starlight to end users, we would need to add a changeset.

Would you be up for that? I can also help you with that if you want, altho, as a non-native speaker, I'm not sure if the PR only improves the translation or if it also fixes some typos or grammar issues so we can best describe the changes in the changeset.

@jsparkdev
Copy link
Copy Markdown
Member Author

jsparkdev commented May 2, 2025

@HiDeoo

Thanks, I missed about that.

And this PR is about making the existing translation even better!

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsparkdev! Just left some quick questions — up to you if you want to change anything in the translation or if you think it’s good like this.

Comment on lines +8 to 10
"themeSelect.dark": "어두운 테마",
"themeSelect.light": "밝은 테마",
"themeSelect.auto": "자동",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely trust you to make the best translation, but just noting that in most languages this is only the colour, e.g. “Light” or “Dark” and doesn’t also include the word “theme”, so you have the accessible “테마 선택” label followed by the theme name and it looks like for the “auto” variant, this is still the case: “자동”, even though the light and dark translations include “theme” (“테마”).

That is totally fine if the meaning here is otherwise unclear and “테마” helps to clarify it but wanted to note it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very reasonable question, and it's something I also considered carefully.

You're right that in English, 'Dark' and 'Light' are common conventions likely understood as 'Dark Theme' and 'Light Theme'.

However, in Korean, using just the adjective form – like '어두운' (eodun - meaning 'dark') or '밝은' (balgeun - meaning 'light') – as a standalone UI option often feels grammatically awkward or incomplete. It leaves the user wondering, "Dark what?". This might be a key difference compared to how adjectives function in English UI labels.

I also tried using the loanwords '다크' (Dark) and '라이트' (Light), but they similarly felt somewhat unnatural or abrupt when used alone in this context.

Therefore, to ensure the meaning is absolutely clear and feels natural to Korean users, I decided to explicitly add the noun '테마' (Theme) after the adjective, resulting in '어두운 테마' (Dark Theme) and '밝은 테마' (Light Theme). Although this deviates slightly from the structure in other languages by adding a word, I believe prioritizing clarity and naturalness for the target audience is the best approach here.

(Optional addition regarding 'Auto'): For the 'Auto' option, the Korean word '자동' (jadong) works perfectly well on its own because it describes the method of theme selection (automatic) rather than a specific visual style like 'dark' or 'light'.

Comment on lines +19 to +20
"page.previousLink": "이전 페이지",
"page.nextLink": "다음 페이지",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And similarly here: most languages just include “Next”/“Previous” without specifying “page”. But if “페이지” here helps to clarify the meaning, then it’s fine 👍

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is the same. By modifying the format of the original English expression, I removed the incomplete feeling from the Korean and added clarity and naturalness for the target users.

jsparkdev and others added 2 commits May 2, 2025 22:20
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the detailed and thoughtful explanations @jsparkdev! Great that the translations are in your careful hands 💖

@delucis delucis dismissed HiDeoo’s stale review May 2, 2025 13:35

Changeset was added!

@delucis delucis added the 🌟 patch Change that triggers a patch release label May 2, 2025
@delucis delucis merged commit ca693fe into withastro:main May 2, 2025
16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 2, 2025
@jsparkdev jsparkdev deleted the ko branch May 2, 2025 13:42
HiDeoo added a commit to hippotastic/starlight that referenced this pull request May 14, 2025
* main: (151 commits)
  i18n(fr): update slot translation and update Astro Docs links (withastro#3196)
  i18n(ko-KR): update `plugins.mdx` (withastro#3197)
  i18n(fr): update `resources/plugins` (withastro#3195)
  chore(deps): update changesets/action action to v1.5.2 (withastro#3191)
  docs(plugins) Add a link to starlight-scroll-to-top plugin (withastro#3194)
  [ci] format
  docs(showcase): add fluid-dnd showcase (withastro#3193)
  [ci] format
  Cookie API website for Showcase (withastro#3188)
  chore(deps): update changesets/action action to v1.5.1 (withastro#3187)
  [ci] format
  add showcase sonar (withastro#3183)
  [ci] release (withastro#3166)
  Prevent heading anchor links on non-Starlight content (withastro#3181)
  i18n(de): update `css-and-tailwind.mdx` (withastro#3174)
  chore(deps): update changesets/action action to v1.5.0 (withastro#3179)
  i18n(ko-KR): update Korean UI strings (withastro#3168)
  i18n(fr): update `guides/css-and-tailwind.mdx` (withastro#3173)
  i18n(ko-KR): update `css-and-tailwind.mdx` (withastro#3172)
  docs: update Tailwind manual installation instructions (withastro#3170)
  ...
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts 🌟 patch Change that triggers a patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants