Skip to content

Fix image metadata validation in StarlightPage schema#3118

Merged
delucis merged 7 commits intomainfrom
chris/svg
Apr 16, 2025
Merged

Fix image metadata validation in StarlightPage schema#3118
delucis merged 7 commits intomainfrom
chris/svg

Conversation

@delucis
Copy link
Copy Markdown
Member

@delucis delucis commented Apr 15, 2025

Description

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2025

🦋 Changeset detected

Latest commit: 7a72743

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package 🌟 markdoc Changes to Starlight’s Markdoc package labels Apr 15, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 7a72743
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67ff60f61decac00088578ec
😎 Deploy Preview https://deploy-preview-3118--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Apr 15, 2025

size-limit report 📦

Path Size
/index.html 6.93 KB (0%)
/_astro/*.js 25.76 KB (0%)
/_astro/*.css 13.92 KB (0%)

Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! I really like this custom validator

@delucis delucis added the 🌟 patch Change that triggers a patch release label Apr 16, 2025
@delucis delucis added this to the v0.34 milestone Apr 16, 2025
@delucis delucis added ✅ approved Pull requests that have been approved and are ready to merge when next cutting a release and removed 📚 docs Documentation website changes labels Apr 16, 2025
@delucis delucis merged commit 77a1104 into main Apr 16, 2025
15 checks passed
@delucis delucis deleted the chris/svg branch April 16, 2025 09:28
@astrobot-houston astrobot-houston mentioned this pull request Apr 16, 2025
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 16, 2025
* main:
  [ci] release (withastro#3124)
  Fix E2E tests broken by formatter
  [ci] format
  Add built-in heading anchor link support (withastro#3033)
  i18n(fr): update `environmental-impact` (withastro#3123)
  Cascade Layers (withastro#2322)
  Fix image metadata validation in StarlightPage schema (withastro#3118)
  Don’t set defaults for `attrs` and `content` in head entries (withastro#3122)
  [ci] format
  i18n(es) Translate `route-data` (withastro#3071)
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ approved Pull requests that have been approved and are ready to merge when next cutting a release 🌟 core Changes to Starlight’s main package 🌟 markdoc Changes to Starlight’s Markdoc package 🌟 patch Change that triggers a patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SVG imports fail schema validation

3 participants