🦋 Changeset detected

Latest commit: 435ef9b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

✅ Deploy Preview for astro-starlight ready!

Name	Link
🔨 Latest commit	435ef9b
🔍 Latest deploy log	https://app.netlify.com/sites/astro-starlight/deploys/67fccf3c2276d40008212d26
😎 Deploy Preview	https://deploy-preview-3109--astro-starlight.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

So it's going to be a bit more complex than just a version bump.

So it's going to be a bit more complex than just a version bump.

Thanks for the contribution 🙌

Not at a computer right now to take a very close look, but sharing a few early pointers regarding the issues:

• The type errors are types tests in the Starlight code base that ensures feature parity between the Expressive Code <Code> component and its equivalent in the Starlight Markdoc preset. I'm assuming some props were updated/added in the <Code> component in this new version, and we probably need to reflect these changes in the Markdoc preset.
• The accessibility warnings may be a bit more concerning, would probably need some investigation to see if it's a regression in the new version, some adjustments that need to be made in our EC configuration or something else.

Let me know if you want to me to take a closer look at any of these issues, give you a bit more guidance around them or if you want to take a stab at investigating them yourself. Thanks again for the contribution.

Thanks for the PR @dhruvkb and for taking an early look @HiDeoo. Probably good to ping @hippotastic on this too just so he’s aware!

Looking at the a11y errors, I spotted this difference for example:

Before	This PR

All the other failing contrast checks seem to be related to code marking styles too.

The error message in the <Code> types test are a bit confusing but I suspect the component may need updating for the new hangingIndent prop this release added.

The accessibility warnings are from upstream. Created this issue to track: expressive-code/expressive-code#323

Thank you for the ping! I'll release a fix in the next few minutes.

I think this shows how great it is to have automated a11y checks! I have some of my own in EC already, but apparently I'll need to upgrade them to use the same tool Starlight uses as well. :)

The patch is live now as EC version 0.41.1 on NPM. If you bump the version again to this patch, the tests should no longer fail.

Thanks @HiDeoo for looking into the PR and for the quick feedback on the failures, thanks @delucis for pointing out the new hangingIndent prop and thanks @hippotastic for patching and releasing v0.41.1 so quickly.

All checks are passing now, excited to be able to use this update!

All checks are passing now, excited to be able to use this update!

Great work, this PR looks good to me!

In case you want to use your new EC feature before the next Starlight release, I'd like to point out that you can use the following method explained in the EC docs to use the latest version earlier:

https://expressive-code.com/upgrading/#overriding-expressive-code-within-starlight

Thanks @hippotastic, guess I should've read the manual. I could've avoided all this work 🤦‍♂️ for myself and everyone else here.

I'm really grateful for your work contributing your new feature to EC and even making the version bump PR here that turned out to be more than a version bump!