Skip to content

feat: Add Substack icon to social list#3013

Merged
delucis merged 6 commits intowithastro:mainfrom
oluwatobiss:feat/add-substack-icon-to-social-list
Mar 26, 2025
Merged

feat: Add Substack icon to social list#3013
delucis merged 6 commits intowithastro:mainfrom
oluwatobiss:feat/add-substack-icon-to-social-list

Conversation

@oluwatobiss
Copy link
Copy Markdown
Contributor

This PR adds Substack's icon to the social links list.

Substack's icon in Starlight site's header

Optimized SVG with SVGOMG.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 24, 2025

🦋 Changeset detected

Latest commit: 807c918

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Mar 24, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 24, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 807c918
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67e4001093c1ce00084cd394
😎 Deploy Preview https://deploy-preview-3013--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@oluwatobiss oluwatobiss changed the title Feat/add substack icon to social list feat: Add Substack icon to social list Mar 25, 2025
Copy link
Copy Markdown
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

But could you maybe remove the pnpm-lock.yaml changes? Just copy the one from main branch and push again.
Because I think these changes shouldn't be here...

@oluwatobiss
Copy link
Copy Markdown
Contributor Author

pnpm-lock.yaml

Sure. I've updated it.

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oluwatobiss! And thank you too to @trueberryless for reviewing 🙌

@delucis delucis added the 🌟 patch Change that triggers a patch release label Mar 26, 2025
@delucis delucis merged commit 5b599dd into withastro:main Mar 26, 2025
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Mar 26, 2025
@oluwatobiss oluwatobiss deleted the feat/add-substack-icon-to-social-list branch March 27, 2025 13:42
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 4, 2025
* main: (43 commits)
  [ci] format
  i18n(ru): update some translations (withastro#3029)
  chore(deps): update zephyrproject-rtos/action-first-interaction digest to 5885399 (withastro#3027)
  [ci] release (withastro#3022)
  feat: add sourcehut as social option (withastro#3020)
  feat: Add Substack icon to social list (withastro#3013)
  [ci] format
  i18n(zh-cn): Update `overrides.md` and `overriding-components.mdx` (withastro#3006)
  [ci] format
  i18n(zh-cn): Update `i18n.mdx` and Update `plugins.md` (withastro#2940)
  i18n(ko-KR): update `ko.json` (withastro#3021)
  i18n(fr): update `resources/themes` (withastro#3019)
  [ci] format
  Update themes.mdx (withastro#3016)
  i18n(ko-KR): update `theme.mdx` (withastro#3015)
  Add starlight theme nova (withastro#3012)
  i18n(fr): update `reference/plugins.md` (withastro#3011)
  i18n(ko-KR): update `plugins.md` (withastro#3010)
  i18n(de): update `plugins.mdx` (withastro#3009)
  Fix code example in plugin reference (withastro#3005)
  ...
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: trueberryless <99918022+trueberryless@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants