Skip to content

Support multisite search on pagefind#2858

Merged
delucis merged 27 commits intowithastro:mainfrom
XREvo:main
Feb 15, 2025
Merged

Support multisite search on pagefind#2858
delucis merged 27 commits intowithastro:mainfrom
XREvo:main

Conversation

@XREvo
Copy link
Copy Markdown
Contributor

@XREvo XREvo commented Feb 4, 2025 •
edited
Loading

Description

This had been tested locally with 2 instances :

  • one on port 3000 and the other on port 3001
  • with this configuration
export default defineConfig({
	... ,
	integrations: [
		starlight({
			...,
			pagefind: {
				indexWeight: 2.0,
				mergeIndex: [{
					bundlePath: 'http://localhost:3001/pagefind/',
					indexWeight: 0.5,
				}]
			},
		}),
	],
});
  • and network panel show that both sites where queried for search
    image

What's next

  • Completing the doc to let users known that they can use it (i'll do it in the the next days)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 4, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 97a4f6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Feb 4, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 97a4f6f
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67ae1703ec243c0008436fa7
😎 Deploy Preview https://deploy-preview-2858--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Feb 4, 2025

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 5, 2025
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Feb 5, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/configuration.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@XREvo XREvo marked this pull request as ready for review February 5, 2025 21:36
delucis
delucis reviewed Feb 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @XREvo! I’ve left a few comments.

One additional note: could you remove the changes to the non-English docs? In general we only change the English docs in implementation PRs and then allow our translators to update their individual languages to ensure they can fully update things correctly for their linguistic context.

@github-actions github-actions bot removed the i18n Anything to do with internationalization & translation efforts label Feb 6, 2025
@XREvo
Copy link
Copy Markdown
Contributor Author

XREvo commented Feb 6, 2025

I've reverted my modification of translations with 10d9967

@XREvo
Copy link
Copy Markdown
Contributor Author

XREvo commented Feb 6, 2025

I let you resolve the conversations after review and i'm waiting for your feedback about the mergeFilter property.
And thanks for the review 🙏

delucis
delucis reviewed Feb 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience on this one @XREvo! I think it looks good, and the mergeFilter schema seems correct to me.

I left a bunch of comments, but please don’t feel overwhelmed — they’re all tiny details to improve the documentation/comments 😁

I’m also happy to handle applying these if you prefer.

XREvo and others added 6 commits February 13, 2025 14:03
@XREvo @delucis
fix: Wording typo
6563d55 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@XREvo @delucis
fix: Wording typo
4741df5 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@XREvo @delucis
fix: Closing lines of comments
7cb26c5 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@XREvo @delucis
fix: Link to doc
042dbc1 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@XREvo @delucis
fix: Link to doc
c0728dd 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@XREvo @delucis
fix: Link to doc
bead418 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
XREvo and others added 6 commits February 13, 2025 14:06
@XREvo @delucis
fix: Doc comment
faa9d33 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@XREvo @delucis
fix: Remove useless documentation
c50177a 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@XREvo @delucis
fix: Remove link to pagefind's code
be6f86a 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@XREvo @delucis
fix: Error in TS documentation
ab8a526 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@XREvo @delucis
fix: Wording in TS doc
a11d499 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@XREvo @delucis
fix: Typing in ref doc
fba1216 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@XREvo
Copy link
Copy Markdown
Contributor Author

XREvo commented Feb 13, 2025

Thanks @delucis for this careful review
I've added all your changes, they were legit to my eyes.

@delucis delucis added the 🌟 minor Change that triggers a minor release label Feb 13, 2025
delucis
delucis approved these changes Feb 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR @XREvo! Will get this published as part of our next minor release 🙌

@delucis delucis merged commit 2df9d05 into withastro:main Feb 15, 2025
@astrobot-houston astrobot-houston mentioned this pull request Feb 15, 2025
Merged
@delucis delucis added this to the v0.32 milestone Feb 15, 2025
trueberryless added a commit to trueberryless/withastro-starlight that referenced this pull request Feb 15, 2025
@trueberryless
update translation with withastro#2858
0eb46f3
@trueberryless trueberryless mentioned this pull request Feb 15, 2025
Merged
@HiDeoo HiDeoo mentioned this pull request Feb 16, 2025
Merged
@jsparkdev jsparkdev mentioned this pull request Feb 16, 2025
Merged
@liruifengv liruifengv mentioned this pull request Mar 5, 2025
Merged
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
@XREvo @delucis
Support multisite search on pagefind (withastro#2858)
fe29fb6 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HiDeoo HiDeoo HiDeoo left review comments

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 minor Change that triggers a minor release

Projects

None yet

Milestone

v0.32

Development

Successfully merging this pull request may close these issues.

4 participants

@XREvo @astrobot-houston @delucis @HiDeoo