Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
| import { Icons } from '../../../packages/starlight/components/Icons'; | ||
|
|
||
| interface Props { | ||
| labels?: { |
There was a problem hiding this comment.
This uses the same data structure used in the theme editor for labels which would be nice in case we ever need more labels in the future altho I guess an argument could be made to use a flat string property instead of an object in this case.
| import IconsList from '~/components/icons-list.astro'; | ||
|
|
||
| <IconsList /> | ||
| <IconsList labels={{ copied: 'Copied!' }} /> |
There was a problem hiding this comment.
Duplicated with the component default label but marks translations as outdated.
| --- | ||
|
|
||
| <div class="icons-grid"> | ||
| <div class="icons-grid" data-label-copied={copied}> |
There was a problem hiding this comment.
The "copied" label is added only once to the DOM and not for every icons.
There was a problem hiding this comment.
Perfect. We could even delegate the click handling here too I guess to avoid assigning a listener for every button? Doesn’t have to be in this PR though!
delucis
left a comment
There was a problem hiding this comment.
Looks great! Tested a few pages including ones with fallback content and everything seems to be working as expected. Happy we can get this content translated properly too 🙌
Description
This PR implements tiny i18n related improvements for the documentation:
slugToLocaleData()internal dependency in the languages list component in favor of usingAstro.currentLocale.reference/icons#2343 (review)