Skip to content

i18n(fr): add reference/icons#2343

Merged
HiDeoo merged 2 commits intowithastro:mainfrom
HiDeoo:hd-i18n-fr-0-28-0-reference-icons
Sep 18, 2024
Merged

i18n(fr): add reference/icons#2343
HiDeoo merged 2 commits intowithastro:mainfrom
HiDeoo:hd-i18n-fr-0-28-0-reference-icons

Conversation

@HiDeoo
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo commented Sep 18, 2024

Description

This PR adds the French version of the reference/icons page with the changes from #2121.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8b8113f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Sep 18, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 18, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 8b8113f
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66eb11c1e203bb000808e5d3
😎 Deploy Preview https://deploy-preview-2343--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Sep 18, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr reference/icons.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

delucis
delucis approved these changes Sep 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Noting that we’ve never added a copiedLabel prop to <IconsList /> for translations so it always shows “Copied!”

Could be something to add in the future.

@HiDeoo
Copy link
Copy Markdown
Member Author

HiDeoo commented Sep 18, 2024

Looks great! Noting that we’ve never added a copiedLabel prop to <IconsList /> for translations so it always shows “Copied!”

Could be something to add in the future.

Technically, we could now also use Astro.locals.t('expressiveCode.copyButtonCopied') but it's not available in a lot of languages I think.

@delucis
Copy link
Copy Markdown
Member

delucis commented Sep 18, 2024

Technically, we could now also use Astro.locals.t('expressiveCode.copyButtonCopied') but it's not available in a lot of languages I think.

Yeah that’s true. Also for these one-off components I think I actually prefer the prop approach because then you are prompted to translate it in the same place as the translated content. Annoying for a component that gets repeated many times, but if only used once like this or the theme editor, then I think considering part of the “content” makes sense I think.

thomasbnt
thomasbnt approved these changes Sep 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@HiDeoo HiDeoo merged commit b2bba73 into withastro:main Sep 18, 2024
@HiDeoo HiDeoo deleted the hd-i18n-fr-0-28-0-reference-icons branch September 18, 2024 17:49
@HiDeoo HiDeoo mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

@thomasbnt thomasbnt thomasbnt approved these changes

Assignees

No one assigned

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HiDeoo @astrobot-houston @delucis @thomasbnt