Skip to content

i18n(de): update translation reference/configuration#2459

Merged
HiDeoo merged 8 commits intowithastro:mainfrom
trueberryless:i18n-con
Oct 22, 2024
Merged

i18n(de): update translation reference/configuration#2459
HiDeoo merged 8 commits intowithastro:mainfrom
trueberryless:i18n-con

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

@trueberryless trueberryless commented Oct 9, 2024 •
edited
Loading

Description

Translation of reference/configuration.mdx into German language.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3a3d469

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Oct 9, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 3a3d469
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67177279886d7a00084a0ca7
😎 Deploy Preview https://deploy-preview-2459--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Oct 9, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de reference/configuration.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@trueberryless trueberryless mentioned this pull request Oct 9, 2024
Merged
@trueberryless trueberryless mentioned this pull request Oct 9, 2024
Merged
@trueberryless
Copy link
Copy Markdown
Contributor Author

trueberryless commented Oct 9, 2024

Link fixed in #2458

@trueberryless
Copy link
Copy Markdown
Contributor Author

trueberryless commented Oct 9, 2024

Link fixed in #2464

This was referenced Oct 20, 2024
Merged
Merged
Merged
Merged
Merged
HiDeoo
HiDeoo requested changes Oct 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. Left a few comments regarding some missing changes but otherwise, this looks good to me.

docs/src/content/docs/de/reference/configuration.mdx Outdated
label: 'Collapsed Links',
label: 'Zusammengeklappte Links',
collapsed: true,
items: [
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example seems to be missing the changes from https://github.com/withastro/starlight/pull/1874/files#diff-889e6ae5a36c15d03a30012e2936df94a63753b335bd5a8c56fac9a42e5c1dff and also proper highlights.

docs/src/content/docs/de/reference/configuration.mdx

**Typ:** `string`
**Standard:** `'/favicon.svg'`
**Voreinstellung:** `'/favicon.svg'`
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot suggest a change for it as it's outside of the review range but the second example in this section is missing the change from https://github.com/withastro/starlight/pull/1627/files#diff-889e6ae5a36c15d03a30012e2936df94a63753b335bd5a8c56fac9a42e5c1dff

@trueberryless
Copy link
Copy Markdown
Contributor Author

trueberryless commented Oct 21, 2024

Thanks for the review!

I think it should be good to go... I'm working from a smartphone, so I would really appreciate it if you check especially the highlighting of the code block mentioned and general if all missing changes are now translated! Thanks in advance!

HiDeoo
HiDeoo approved these changes Oct 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR, everything looks good now 🚀 I'll temporarily merge with broken links so they can be fixed in the next PRs.

@HiDeoo HiDeoo merged commit 88455b2 into withastro:main Oct 22, 2024
@trueberryless trueberryless deleted the i18n-con branch October 22, 2024 11:44
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Oct 23, 2024
@HiDeoo
Merge branch 'main' into hd-perf-sidebar-cache
bc649ce 
* main: (240 commits)
  i18n(de): update some files for consistency in German language (withastro#2502)
  i18n(zh-cn): Update `plugins.mdx` (withastro#2501)
  i18n(de): translate guides/pages (withastro#2469)
  i18n(de): translate components/code (withastro#2457)
  i18n(de): translate components/using-components (withastro#2455)
  [ci] format
  i18n(de): translate guides/site-search (withastro#2481)
  i18n(de): update translation guides/customization (withastro#2475)
  i18n(de): update translation manual-setup (withastro#2479)
  i18n(de): update translation reference/overrides (withastro#2480)
  i18n(de): translate reference/plugins (withastro#2464)
  i18n(de): update translation guides/authoring-content (withastro#2458)
  [ci] format
  i18n(de): update translation reference/configuration (withastro#2459)
  i18n(de): update translation reference/frontmatter (withastro#2470)
  [ci] format
  i18n(de): update translation guides/i18n (withastro#2476)
  i18n(de): update `resources/plugins.mdx` (withastro#2498)
  i18n(ko-KR): update `plugins.mdx` (withastro#2500)
  i18n(fr): Update `resources/plugins` from withastro#2493 (withastro#2496)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees

No one assigned

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trueberryless @astrobot-houston @HiDeoo