Skip to content

Merge <link rel="canonical" /> tags, quick fixes (#2153)#2154

Merged
delucis merged 4 commits intowithastro:mainfrom
mktbsh:bugfix/merge-head-canonical
Jul 27, 2024
Merged

Merge <link rel="canonical" /> tags, quick fixes (#2153)#2154
delucis merged 4 commits intowithastro:mainfrom
mktbsh:bugfix/merge-head-canonical

Conversation

@mktbsh
Copy link
Copy Markdown
Contributor

@mktbsh mktbsh commented Jul 26, 2024

Description

  • Closes Duplicate canonical tags when specifying in frontmatter.head #2153
  • What does this PR change? Give us a brief description.
    • This PR modifies the hasTag function in starlight/utils/head.ts to include a check for link tags. Specifically, it ensures that if a link tag has rel="canonical", duplicates are not allowed.
  • Did you change something visual? A before/after screenshot can be helpful.
    • nothing

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 26, 2024

🦋 Changeset detected

Latest commit: 171e393

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Jul 26, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 26, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 171e393
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66a52ac7e7369000083628d0
😎 Deploy Preview https://deploy-preview-2154--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @mktbsh — the tests look good! I left a couple of small comments.

@delucis delucis added the 🌟 patch Change that triggers a patch release label Jul 27, 2024
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this update @mktbsh — welcome to the Starlight contributors 🎉

@delucis delucis merged commit 0b381d5 into withastro:main Jul 27, 2024
@astrobot-houston astrobot-houston mentioned this pull request Jul 24, 2024
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Aug 6, 2024
* main: (275 commits)
  [ci] release (withastro#2165)
  Define well-known RTL locales before calling `getLocaleInfo()` for default locale (withastro#2167)
  Update dependencies (withastro#2166)
  Improve page load performance (withastro#2155)
  docs: Add CodeSweetly to showcase (withastro#2160)
  [ci] release (withastro#2145)
  Fix bug for projects with spaces in their pathname (withastro#2156)
  ci: update file icons (withastro#2157)
  [ci] format
  Merge <link rel="canonical" /> tags, quick fixes (withastro#2153) (withastro#2154)
  Add two new showcase sites (withastro#2149)
  [ci] format
  i18n(zh-cn): Update `environmental-impact.md` (withastro#2148)
  add Saasfly showcase (withastro#2147)
  docs: add 'og:image:alt' metadata (withastro#2143)
  Deleting unnecessary twitter meta tags, quick fixes (withastro#2137)
  [ci] format
  i18n(es): update `environmental-impact` (withastro#2144)
  [ci] release (withastro#2142)
  feat: Add Pinterest icon to social list (withastro#2135)
  ...
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
…thastro#2154)

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate canonical tags when specifying in frontmatter.head

3 participants