Skip to content

i18n(tr): add css-and-tailwind#1893

Merged
HiDeoo merged 5 commits intowithastro:mainfrom
erkanaltinors:css-styling-tr
May 18, 2024
Merged

i18n(tr): add css-and-tailwind#1893
HiDeoo merged 5 commits intowithastro:mainfrom
erkanaltinors:css-styling-tr

Conversation

@erkanaltinors
Copy link
Copy Markdown
Contributor

@erkanaltinors erkanaltinors commented May 18, 2024 •
edited
Loading

What kind of changes does this PR include?

Updates of Starlight docs site content

Description

This pull request;

  • Adds translated in Turkish css-and-tailwind.mdx file into project.
  • Fixes typo in docs/tr/environmental-impact.mdx file into project.

@vercel
Copy link
Copy Markdown

vercel bot commented May 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview May 18, 2024 10:50am

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ab0eb2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels May 18, 2024
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 18, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
tr environmental-impact.md Localization changed, will be marked as complete.
tr guides/css-and-tailwind.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

HiDeoo
HiDeoo requested changes May 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation!

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist and except a missing part of a sentence in the last part, I think everything looks perfect 👍

docs/src/content/docs/tr/guides/css-and-tailwind.mdx Outdated
dosyası içine](#özel-css-stilleri) aşağıdaki CSS'i dahil edin ve projenize ekleyin.
</Fragment>
<Fragment slot="tailwind-docs">
Aşağıdaki [Tailwind yapılandırma dosyasına ait](#tailwind-ile-starlightı-stillendirme) örnek, yapılandırma nesnesi içerisinde oluşturulmuş `accent` ve `gray` renk paletlerini dahil eder.
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sentence is missing the theme.extend.colors reference that exists in the English version.

Copy link
Copy Markdown
Contributor Author

@erkanaltinors erkanaltinors May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @HiDeoo , you are right! I've translated the sentence you mentioned.

HiDeoo
HiDeoo approved these changes May 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for the fast update, let's merge this one 🚀

@HiDeoo HiDeoo merged commit b28e2c1 into withastro:main May 18, 2024
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request May 20, 2024
@HiDeoo
Merge branch 'main' into hd-refactor-astro-i18n
897f0bf 
* main: (45 commits)
  i18n(tr): add `showcase.mdx` (withastro#1896)
  [ci] format
  i18n(zh-cn): Update `authoring-content.md` (withastro#1901)
  [ci] format
  [ci] release (withastro#1897)
  [ci] format
  i18n(tr): update `authoring-content.md` (withastro#1887)
  Micro-optimization: clean up `<details>` CSS (withastro#1892)
  [ci] format
  i18n(tr): update `components.md` file (withastro#1889)
  [ci] format
  i18n(tr): add css-and-tailwind (withastro#1893)
  [ci] format
  [ci] release (withastro#1890)
  Adds custom styles for `<details>` and `<summary>` elements in Markdown content (withastro#1735)
  Update @astrojs/mdx to v3 (withastro#1846)
  [ci] format
  [ci] release (withastro#1869)
  Add BlueSky social icon (withastro#1871)
  [ci] format
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees

No one assigned

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erkanaltinors @astrobot-houston @HiDeoo