Skip to content

Adds starlight icon to Starlight#1698

Merged
delucis merged 3 commits intowithastro:mainfrom
liruifengv:add-starlight-icon
Apr 1, 2024
Merged

Adds starlight icon to Starlight#1698
delucis merged 3 commits intowithastro:mainfrom
liruifengv:add-starlight-icon

Conversation

@liruifengv
Copy link
Copy Markdown
Member

@liruifengv liruifengv commented Mar 30, 2024

Description

Adds starlight icon to Starlight

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 30, 2024

🦋 Changeset detected

Latest commit: 37d8941

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Apr 1, 2024 0:14am

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Mar 30, 2024
@liruifengv liruifengv requested a review from delucis March 30, 2024 07:17
@liruifengv liruifengv changed the title Adds starlight icon for Starlight Adds starlight icon to Starlight Mar 30, 2024
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @liruifengv! Better late than never to add our own icon 😁

@delucis delucis added the 🌟 patch Change that triggers a patch release label Apr 1, 2024
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@liruifengv
Copy link
Copy Markdown
Member Author

image

I think it will be interesting if we update the docs!

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you @liruifengv 🌟

Re: your suggested the docs change — do you think it could be confusing to people? My only concern is if it might be a bit less obvious that the Starlight logo is an icon compared to the more generic star.

@liruifengv
Copy link
Copy Markdown
Member Author

star

Yeah. Star is good.

HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 5, 2024
* main: (111 commits)
  Fix various Expressive Code translation issues (withastro#1708)
  Fix nested aside title rendering issue (withastro#1703)
  I18n(pt-PT): Add resources pages (withastro#1678)
  Add SST Ion & Font Awesome to site showcase (withastro#1710)
  [ci] format
  Add SudoVanilla to showcase (withastro#1702)
  i18n(fr): Update `resources-showcase` (withastro#1697)
  [i18nIgnore] docs: update `starlight-links-validator` to version `0.7.1` (withastro#1696)
  [ci] format
  [ci] release (withastro#1688)
  [ci] format
  Update Russian translation (withastro#1616)
  [ci] format
  Adds `starlight` icon to Starlight (withastro#1698)
  Update Icons.ts with Farcaster Purple for SocialIcons (withastro#1622)
  Remove duplicate from showcase example in `contributing.md` (withastro#1692)
  i18n(zh-cn): Update `showcase.mdx` (withastro#1689)
  [ci] format
  i18n(zh-cn): Update configuration.mdx (withastro#1691)
  i18n(ko-KR): update `showcase.mdx` (withastro#1690)
  ...
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants