Skip to content

Add config option to disable 404 page#1389

Merged
delucis merged 7 commits intowithastro:mainfrom
connor-baer:feature/disable-404
Jan 26, 2024
Merged

Add config option to disable 404 page#1389
delucis merged 7 commits intowithastro:mainfrom
connor-baer:feature/disable-404

Conversation

@connor-baer
Copy link
Copy Markdown
Contributor

@connor-baer connor-baer commented Jan 22, 2024 •
edited
Loading

Description

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jan 26, 2024 10:15pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 22, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 09302e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Jan 22, 2024
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jan 22, 2024

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

delucis
delucis reviewed Jan 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @connor-baer! This looks great to me even without the extra todo item — we can always tackle that later. Left one small suggestion on the docs, but the code seems spot on 🙌

@delucis delucis added the 🌟 minor Change that triggers a minor release label Jan 25, 2024
@delucis delucis marked this pull request as ready for review January 26, 2024 19:17
delucis
delucis approved these changes Jan 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution @connor-baer! Hope you don’t mind I jumped in to polish up the last docs changes so we can get this released today.

Appreciate you helping out 🌟

@delucis delucis merged commit 21b3620 into withastro:main Jan 26, 2024
@astrobot-houston astrobot-houston mentioned this pull request Jan 26, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Jan 27, 2024
Merged
@connor-baer
Copy link
Copy Markdown
Contributor Author

connor-baer commented Jan 27, 2024

@delucis, I don't mind at all, thanks for finishing this up! 🙌🏻

@connor-baer connor-baer deleted the feature/disable-404 branch January 27, 2024 11:59
@liruifengv liruifengv mentioned this pull request Jan 29, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
@connor-baer @delucis
Add config option to disable 404 page (withastro#1389)
90a085d 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 minor Change that triggers a minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Subpath: This route collides with: "src/pages/404.astro".

3 participants

@connor-baer @astrobot-houston @delucis