i18n(tr): Translate some files into Turkish#1052
i18n(tr): Translate some files into Turkish#1052hamer1818 wants to merge 34 commits intowithastro:mainfrom
Conversation
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
WOW! This is great work! We really appreciate it. I'm not sure, but I think all i18n pull requests have some kind of "naming convention", so I would almost suggest that you rename the PR to: "i18n(tr): Translate some files into Turkish" However, this is only a small thing and I don't think it's that important... |
İ did. Thanks |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Hi @hamer1818! Thanks again for working on this.
It looks like you haven’t made any of the changes I suggested in #1038. Could you fix those links etc.?
Also noting that #1012 made a small change to the i18n.mdx page — we should update the translation here too.
import LanguagesList
|
Would you look again? Plz |
There was a problem hiding this comment.
Thanks for the update 🙌
As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist.
I left quite a few comment and suggestions but a large majority of them are either related to links that should always point to the /tr/ version of the page, some link anchors that should be updated to the Turkish version of the heading, and some code block syntax highlighting related changes.
If needed, when dealing with suggestions, Chris left you a small guide on how to manage them in this comment.
If you have any questions or you are not sure about something, feel free to join the #starlight channel in the Astro Discord and ask away 😄
|
|
||
| Her sayfanın ana içeriği etrafında görüntülenen bir bileşen. | ||
| Varsayılan uygulama, Markdown içeriğine uygulanacak temel stilleri ayarlar. | ||
|
|
There was a problem hiding this comment.
I think this is missing the changes from https://github.com/withastro/starlight/pull/1049/files#diff-ad80506c0d18072cbd9a85e2090c2be41e5a5523fe9f2991a1c653e41d089591
Would you mind adding the missing sentence?
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
delucis
left a comment
There was a problem hiding this comment.
Hey @hamer1818! Thanks for your patience on this one.
We just added some tooling to help speed up finding broken links which has been one of our bigger issues so far in this PR, so hopefully can get those all fixed now.
At the bottom of the PR you should find a list of “checks”:
If you scroll down, there is a “CI / Check for broken links” check:
Clicking on the “Details” link will take you to a log of all the broken links our CI found. For example, here’s the most recent run for the PR in its current state.
There are two error types:
- “inconsistent locale” — these links should start with
/tr/but currently don’t - “invalid anchor” — these links have a
#part which doesn’t exist on the linked page, I think mainly because they need translating to Turkish instead of using the English original#
If you could fix those, it would be much appreciated. You can test everything is fixed locally by running this command in the docs directory if you like:
CHECK_LINKS=true pnpm build|
Thanks again for the PR and the work on this. I will close the PR for now due to inactivity, but happy to reopen it or look at future PRs if you’re ever still interested! |
What kind of changes does this PR include?
Description
I made a new update in Turkish language