Skip to content

RSS: Add config reference links#9601

Merged
bholmesdev merged 6 commits intomainfrom
edit/rss-config-reference
Oct 11, 2024
Merged

RSS: Add config reference links#9601
bholmesdev merged 6 commits intomainfrom
edit/rss-config-reference

Conversation

@bholmesdev
Copy link
Copy Markdown
Contributor

@bholmesdev bholmesdev commented Oct 8, 2024 •
edited
Loading

Description (required)

Add links to the @astrojs/rss README for a complete configuration reference.

  • Link from the step-by-step guide to call out all config options
  • Link from the items rendering guide to call out the items reference

Related issues & labels (optional)

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 8, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 211c3db
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6707c52d86f864000798994f
😎 Deploy Preview https://deploy-preview-9601--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Oct 8, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/rss.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

ArmandPhilippot
ArmandPhilippot reviewed Oct 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bholmesdev! LGTM, I only added 3 comments (mostly nitpicking). Feel free to ask me for more details if I haven't been clear enough about customData.

bholmesdev and others added 3 commits October 8, 2024 13:22
@bholmesdev @ArmandPhilippot
edit: move link start
f954a49 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@bholmesdev @ArmandPhilippot
edit: move link start
0eb5de2 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@bholmesdev
fix: remove customData from example
b927446
@bholmesdev
Copy link
Copy Markdown
Contributor Author

bholmesdev commented Oct 8, 2024

All very clear! Just removing customData since it's rarely used and best left to config reference

yanthomasdev
yanthomasdev reviewed Oct 8, 2024
View reviewed changes
sarah11918
sarah11918 reviewed Oct 8, 2024
View reviewed changes
sarah11918
sarah11918 reviewed Oct 8, 2024
View reviewed changes
src/content/docs/en/guides/rss.mdx
```
</Steps>

<ReadMore>See the [`@astrojs/rss` README](https://github.com/withastro/astro/tree/main/packages/astro-rss) for the full configuration reference.</ReadMore>
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I really want this turned into an integration, so we just have the standard integration guide page in docs!!

Copy link
Copy Markdown
Contributor Author

@bholmesdev bholmesdev Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, totally agree!

bholmesdev and others added 2 commits October 10, 2024 08:14
@bholmesdev @yanthomasdev
edit: item -> items
2313e26 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@bholmesdev @sarah11918
edit: clarify this is non-exhaustive
211c3db 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
sarah11918 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update Ben!

@bholmesdev bholmesdev merged commit bf9c7f9 into main Oct 11, 2024
@bholmesdev bholmesdev deleted the edit/rss-config-reference branch October 11, 2024 17:09
@jsparkdev jsparkdev mentioned this pull request Oct 12, 2024
Merged
@Nin3lee Nin3lee mentioned this pull request Oct 12, 2024
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Oct 16, 2024
@ArmandPhilippot
i18n(fr): update guides/rss.mdx
9a91bb8 
See withastro#9601
@ArmandPhilippot ArmandPhilippot mentioned this pull request Oct 16, 2024
Merged
yanthomasdev added a commit that referenced this pull request Oct 16, 2024
@ArmandPhilippot @yanthomasdev
i18n(fr): update guides/rss.mdx (#9692)
c04b650 
* i18n(fr): update `guides/rss.mdx`

See #9601

* remove `type: recipe` from the frontmatter

See #8239

* fix some typo, reword, remove blank lines and reorganize imports

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArmandPhilippot ArmandPhilippot ArmandPhilippot left review comments

@yanthomasdev yanthomasdev yanthomasdev left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bholmesdev @astrobot-houston @sarah11918 @ArmandPhilippot @yanthomasdev