Skip to content

i18n(fr): Update reference/configuration-reference.mdx from #8967#8972

Merged
yanthomasdev merged 4 commits intowithastro:mainfrom
thomasbnt:i18n-update-reference-configuration-reference
Aug 1, 2024
Merged

i18n(fr): Update reference/configuration-reference.mdx from #8967#8972
yanthomasdev merged 4 commits intowithastro:mainfrom
thomasbnt:i18n-update-reference-configuration-reference

Conversation

@thomasbnt
Copy link
Copy Markdown
Member

@thomasbnt thomasbnt commented Aug 1, 2024

Description (required)

Related issues & labels (optional)

  • Suggested label: i18n

@thomasbnt
i18n(fr): Update reference/configuration-reference.mdx from withast…
df1e864 
…ro#8967

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Replace NBSP with spaces
78c3204 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Aug 1, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 1, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 860a9ba
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66abfe9f591aec000895e323
😎 Deploy Preview https://deploy-preview-8972--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Aug 1, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr reference/configuration-reference.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@thomasbnt
Copy link
Copy Markdown
Member Author

thomasbnt commented Aug 1, 2024

Note

The CI link mark an error at L20 on the rewrite-with-body-used.mdx :
[Astro.rewrite](/fr/reference/configuration-reference/#experimentalrewriting)
This part is deleted from https://github.com/withastro/docs/pull/8967/files#diff-6b0ed61bf17daf5f370edd2d5a46be46cb8ef5321ac7537a17e71236f0c9028bL1484-L1538, the PR #8972 is opened for this modification.

ArmandPhilippot
ArmandPhilippot approved these changes Aug 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

However I don't understand the usefulness of the second commit: in France, some punctuation should use no-break spaces or narrow no-break spaces (fr, sorry I didn't find any source in English).

@thomasbnt
Copy link
Copy Markdown
Member Author

thomasbnt commented Aug 1, 2024

However I don't understand the usefulness of the second commit: in France, some punctuation should use no-break spaces or narrow no-break spaces (fr, sorry I didn't find any source in English).

In all files, the space is marked by a space, not a no-break space. So I've changed it to be consistent throughout the doc.

yanthomasdev
yanthomasdev approved these changes Aug 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job!

@yanthomasdev yanthomasdev merged commit aa26e12 into withastro:main Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thomasbnt @astrobot-houston @ArmandPhilippot @yanthomasdev