Skip to content

Update images.mdx#7856

Merged
sarah11918 merged 7 commits intowithastro:mainfrom
rishi-raj-jain:patch-1
Apr 17, 2024
Merged

Update images.mdx#7856
sarah11918 merged 7 commits intowithastro:mainfrom
rishi-raj-jain:patch-1

Conversation

@rishi-raj-jain
Copy link
Copy Markdown
Contributor

@rishi-raj-jain rishi-raj-jain commented Apr 11, 2024 •
edited
Loading

Description (required)

Showcases the use of the relative image path without leading ./ in MDX file(s).

I am proposing this change in Astro docs to show how Astro users can use the particular functionality.

Yup, I've made change in only the english docs.

Related issues & labels (optional)

The related PR is withastro/astro#10754

@rishi-raj-jain rishi-raj-jain mentioned this pull request Apr 11, 2024
Closed
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 17, 2024 11:08pm

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Apr 11, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/images.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@rishi-raj-jain rishi-raj-jain mentioned this pull request Apr 11, 2024
Merged
Rishi Raj Jain added 2 commits April 16, 2024 11:27
@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Apr 16, 2024
sarah11918
sarah11918 reviewed Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion below!

@sarah11918 sarah11918 added the code snippet update Updates a code sample: typo, outdated code etc. label Apr 16, 2024
Rishi Raj Jain and others added 2 commits April 16, 2024 20:08
@sarah11918
Update src/content/docs/en/guides/images.mdx
0d8bcab 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Merge branch 'main' into patch-1
53f8538
sarah11918
sarah11918 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good and will be ready to merge when the next release goes out!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Apr 16, 2024
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Apr 17, 2024

Looks like this was released, so good to merge now! 🥳

@sarah11918 sarah11918 merged commit ba35f74 into withastro:main Apr 17, 2024
@huyikai huyikai mentioned this pull request Apr 18, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Apr 18, 2024
Merged
This was referenced Apr 21, 2024
Merged
Merged
@McFlyPartages McFlyPartages mentioned this pull request Apr 26, 2024
Merged
tarikrital pushed a commit to tarikrital/astro-docs that referenced this pull request May 15, 2024
@sarah11918 @tarikrital
Update images.mdx (withastro#7856)
536b8a5 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
tarikrital pushed a commit to tarikrital/astro-docs that referenced this pull request May 15, 2024
@sarah11918 @tarikrital
Update images.mdx (withastro#7856)
98b7d1c 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rishi-raj-jain @astrobot-houston @sarah11918