Skip to content

Update docs for withastro/astro#9610#6154

Merged
bluwy merged 2 commits intomainfrom
feat/optional-rss-title
Jan 11, 2024
Merged

Update docs for withastro/astro#9610#6154
bluwy merged 2 commits intomainfrom
feat/optional-rss-title

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

@florian-lefebvre florian-lefebvre commented Jan 5, 2024 •
edited
Loading

Description (required)

Updates the RSS guide.

Related issues & labels (optional)

  • Suggested label: merge-on-release

For @astrojs/rss@4.0.2 (patch)

See withastro/astro#9610

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 5, 2024 2:37pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 2:37pm

@florian-lefebvre florian-lefebvre mentioned this pull request Jan 5, 2024
Merged
@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. labels Jan 5, 2024
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Jan 5, 2024

@florian-lefebvre Thank you for updating this! I took a general editing pass because now that paragraph seemed like it was getting a little long (and repetitive with title/description). I also took the opportunity to clean up some other text. See what you think!

Note that I removed the caution because we already had a note in the relevant section, but added a further strong warning inside that existing note.

@florian-lefebvre
Copy link
Copy Markdown
Member Author

florian-lefebvre commented Jan 5, 2024

Sounds good!

sarah11918
sarah11918 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Then the last thing to do is please update the original description with the expected release version of Astro (as suggested by the template when you open it) This helps us easily scan the "merge on release" to know if these are for minor releases, or patches etc. Otherwise, this'll be good to go!

@florian-lefebvre
Copy link
Copy Markdown
Member Author

florian-lefebvre commented Jan 5, 2024

Done!

@bluwy bluwy merged commit 09a2136 into main Jan 11, 2024
@bluwy bluwy deleted the feat/optional-rss-title branch January 11, 2024 08:33
@huyikai huyikai mentioned this pull request Jan 12, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Jan 12, 2024
Merged
@McFlyPartages McFlyPartages mentioned this pull request Jan 13, 2024
Merged
dreyfus92 added a commit that referenced this pull request Jan 13, 2024
@McFlyPartages @dreyfus92
i18n(fr) Update french translation for rss.mdx (#6366)
21fdb42 
* i18n(fr) Update reading-time.mdx

Just for translator tracker because the PR #5766 should have been [ignore]

* Update rss.mdx

With PR #6206

* Update rss.mdx

With PR #6154

---------

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@florian-lefebvre @sarah11918 @ematipico
Update docs for withastro/astro#9610 (#6154)
aa693a0 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@McFlyPartages @dreyfus92 @ematipico
i18n(fr) Update french translation for rss.mdx (#6366)
0556319 
* i18n(fr) Update reading-time.mdx

Just for translator tracker because the PR #5766 should have been [ignore]

* Update rss.mdx

With PR #6206

* Update rss.mdx

With PR #6154

---------

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@florian-lefebvre @sarah11918 @bluwy