Skip to content

Add details on how to test with NightwatchJS#5822

Merged
sarah11918 merged 7 commits intowithastro:mainfrom
AutomatedTester:patch-1
Dec 24, 2023
Merged

Add details on how to test with NightwatchJS#5822
sarah11918 merged 7 commits intowithastro:mainfrom
AutomatedTester:patch-1

Conversation

@AutomatedTester
Copy link
Copy Markdown
Contributor

@AutomatedTester AutomatedTester commented Dec 18, 2023

Description (required)

Added details on how to do the follow with NightwatchJS

  • Install
  • write a test
  • run a test

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@AutomatedTester
Add details on how to test with NightwatchJS
7a283cb 
Added details on how to 

* Install
* write a test
* run a test

Using NightwatchJS.
@vercel
Copy link
Copy Markdown

vercel bot commented Dec 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 24, 2023 2:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Dec 24, 2023 2:18pm

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 18, 2023

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Dec 19, 2023
sarah11918
sarah11918 reviewed Dec 19, 2023
View reviewed changes
sarah11918
sarah11918 reviewed Dec 22, 2023
View reviewed changes
sarah11918
sarah11918 reviewed Dec 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely fabulous, @AutomatedTester ! Thank you for not only a very helpful addition to our docs, but also for so carefully adhering to the established example. It really shows an amazing level of care and consideration that you made this effort to match existing documentation. 💜

I've made some tiny editing suggestions below. Please do verify that the information is still correct, or let me know if anything feels off. It may look like a lot, but they're all quite minor just to polish things off.

See what you think!

sarah11918
sarah11918 approved these changes Dec 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AutomatedTester ! I went ahead and committed my minor edits to this file so that we could get it in before the holidays and have it be helping people right away! I'll merge it as soon as the tests pass, and then if there are things you'd like to change, you can PR edits to it. But this way, we get this wonderful testing info included for our "holiday hackers" 🥳

Thank you again for this wonderful contribution and welcome to Team Docs! 🙌

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Dec 24, 2023
@sarah11918 sarah11918 merged commit 9298cce into withastro:main Dec 24, 2023
@100gle 100gle mentioned this pull request Dec 25, 2023
Merged
@jsparkdev jsparkdev mentioned this pull request Jan 2, 2024
Merged
@McFlyPartages McFlyPartages mentioned this pull request Jan 13, 2024
Merged
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@AutomatedTester @sarah11918 @ematipico
Add details on how to test with NightwatchJS (#5822)
e923a26 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AutomatedTester @astrobot-houston @sarah11918