[i18nIgnore] remove unused listener in sharing state recipe#5727
Merged
delucis merged 3 commits intowithastro:mainfrom Dec 12, 2023
Merged
[i18nIgnore] remove unused listener in sharing state recipe#5727delucis merged 3 commits intowithastro:mainfrom
delucis merged 3 commits intowithastro:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ematipico
pushed a commit
that referenced
this pull request
Jan 26, 2024
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
There is no need to add a listener on the Dialog.astro component is this recipe. The listener is added on the Button.astro example above. The element with the id #openDialog is undefined here
Related issues & labels (optional)