Merged
Conversation
Co-authored-by: Elian <hello@elian.codes> Co-authored-by: Kevin Zuniga Cuellar <kevinzunigacuellar@users.noreply.github.com> Co-authored-by: Atharva Pise <atharvapise19@gmail.com> Co-authored-by: Paul Valladares <dreyfus92@users.noreply.github.com> Co-authored-by: Reuben Tier <TheOtterlord@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: HiDeoo <HiDeoo@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Reuben Tier <TheOtterlord@users.noreply.github.com> Co-authored-by: Genteure <Genteure@users.noreply.github.com> Co-authored-by: Atharva Pise <atharvapise19@gmail.com> Co-authored-by: Kevin Zuniga Cuellar <kevinzunigacuellar@users.noreply.github.com>
Member
|
Looking good |
Co-authored-by: Kevin Zuniga Cuellar <46791833+kevinzunigacuellar@users.noreply.github.com>
Contributor
|
LGTM! Great work :)) |
alexnguyennz
reviewed
Dec 2, 2023
Contributor
alexnguyennz
left a comment
There was a problem hiding this comment.
For consistency e.g. v4.0 used above and below or with v3.0/v3.x directly above - maybe doesn't matter. Otherwise looks good to me.
Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz> Co-authored-by: Kevin Zuniga Cuellar <46791833+kevinzunigacuellar@users.noreply.github.com>
yanthomasdev
reviewed
Dec 3, 2023
Member
yanthomasdev
left a comment
There was a problem hiding this comment.
This is looking great! Left my usual nits.
sarah11918
commented
Dec 3, 2023
Member
Author
sarah11918
left a comment
There was a problem hiding this comment.
Thanks for your review, Yan!
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
sarah11918
commented
Dec 3, 2023
ematipico
pushed a commit
that referenced
this pull request
Jan 26, 2024
Co-authored-by: HiDeoo <HiDeoo@users.noreply.github.com> Co-authored-by: Elian <hello@elian.codes> Co-authored-by: Kevin Zuniga Cuellar <kevinzunigacuellar@users.noreply.github.com> Co-authored-by: Atharva Pise <atharvapise19@gmail.com> Co-authored-by: Paul Valladares <dreyfus92@users.noreply.github.com> Co-authored-by: Reuben Tier <TheOtterlord@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Genteure <Genteure@users.noreply.github.com> Co-authored-by: Kevin Zuniga Cuellar <46791833+kevinzunigacuellar@users.noreply.github.com> Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz> Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
v3 -> v4 upgrade guide with breaking changes
Related issues & labels (optional)