Skip to content

Update MiddlewareResponseHandler docs reference#5238

Merged
sarah11918 merged 2 commits intowithastro:mainfrom
macklinu:patch-1
Oct 31, 2023
Merged

Update MiddlewareResponseHandler docs reference#5238
sarah11918 merged 2 commits intowithastro:mainfrom
macklinu:patch-1

Conversation

@macklinu
Copy link
Copy Markdown
Contributor

Description (required)

This PR updates a reference to MiddlewareResponseHandler in the docs. Previously, the text before an example referred to MiddlewareResponseHandler as MiddlewareRequestHandler, but this change should make the text match with the code sample that follows.

Related issues & labels (optional)

N/A

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 31, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 248cc7b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/654159f31e60fe0008d6c317
😎 Deploy Preview https://deploy-preview-5238--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Contributor

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918 sarah11918 added typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. code snippet update Updates a code sample: typo, outdated code etc. labels Oct 31, 2023
Copy link
Copy Markdown
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me

@sarah11918 sarah11918 merged commit 5444709 into withastro:main Oct 31, 2023
yanthomasdev pushed a commit that referenced this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants