Skip to content

remove trailing comma in tsconfig#4059

Merged
ElianCodes merged 4 commits intomainfrom
elian/trailing-commas
Aug 4, 2023
Merged

remove trailing comma in tsconfig#4059
ElianCodes merged 4 commits intomainfrom
elian/trailing-commas

Conversation

@ElianCodes
Copy link
Copy Markdown
Member

@ElianCodes ElianCodes commented Aug 4, 2023

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • removing trailing commas in tsconfig.json

Description

@ElianCodes ElianCodes added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Aug 4, 2023
@ElianCodes ElianCodes self-assigned this Aug 4, 2023
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 4, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 927ee5e
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/64ccf411a098b2000770f5cd
😎 Deploy Preview https://deploy-preview-4059--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ElianCodes ElianCodes mentioned this pull request Aug 4, 2023
Closed
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Aug 4, 2023
@ElianCodes
Copy link
Copy Markdown
Member Author

ElianCodes commented Aug 4, 2023

Checked i18n on trailing commas as well

@ElianCodes ElianCodes marked this pull request as ready for review August 4, 2023 12:36
@TheOtterlord
Copy link
Copy Markdown
Member

TheOtterlord commented Aug 4, 2023

Thanks!
I checked all other instances of tsconfig.json, and it looks like we have a few snippets in our typescript guide that have the same issue. Obviously not all of these are as simple as copy/paste, but they would be more valid syntax without a comma than with one.

@ElianCodes
Copy link
Copy Markdown
Member Author

ElianCodes commented Aug 4, 2023

Aaaah mr @TheOtterlord, what would I do without you!

Fixing them ASAP!

TheOtterlord
TheOtterlord approved these changes Aug 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ElianCodes ElianCodes merged commit aca87e9 into main Aug 4, 2023
@ElianCodes ElianCodes deleted the elian/trailing-commas branch August 4, 2023 13:03
imbant pushed a commit to imbant/Astro-docs that referenced this pull request Aug 7, 2023
@ElianCodes @imbant
remove trailing comma in tsconfig (withastro#4059)
4b94fed
@McFlyPartages McFlyPartages mentioned this pull request Jan 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheOtterlord TheOtterlord TheOtterlord approved these changes

Assignees

@ElianCodes ElianCodes

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Find and fix instances of trailing commas in tsconfig.json

2 participants

@ElianCodes @TheOtterlord