Fix incorrect code examples in the Markdown guide#14032
Merged
ArmandPhilippot merged 2 commits intoJun 10, 2026
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
morinokami
commented
Jun 10, 2026
Comment on lines
+54
to
+61
| const compiled = await greatPost.compiledContent(); | ||
| const posts = Object.values(import.meta.glob('./posts/*.md', { eager: true })); | ||
| --- | ||
|
|
||
| <p>{greatPost.frontmatter.title}</p> | ||
| <p>Written by: {greatPost.frontmatter.author}</p> | ||
|
|
||
| {greatPost.compiledContent()} | ||
| <Fragment set:html={compiled} /> |
Member
Author
There was a problem hiding this comment.
{greatPost.compiledContent()} renders escaped HTML, so the post body appears as literal text. Replaced with await + <Fragment set:html={...} />.
morinokami
commented
Jun 10, 2026
Comment on lines
-279
to
+280
| features: { directive: true, definitionList: true }, | ||
| features: { directive: true }, |
Member
Author
There was a problem hiding this comment.
Removed definitionList: true because no such feature exists per the Sätteri features docs.
HiDeoo
added a commit
that referenced
this pull request
Jun 11, 2026
* main: i18n(ko-KR): update `cosmic`, `markdown-content`, `modified-time` (#14041) i18n(pt-br): Update editor-setup.mdx translation (#14040) i18n(it-IT): create it/guides/fonts.mdx (#13871) i18n(fr): update `guides/astro-db.mdx` & `integrations-guide/db.mdx` (#14033) i18n(fr): update `guides/markdown-content.mdx` (#14034) i18n(fr): update `recipes/modified-time.mdx` (#14035) i18n(fr): update `session-driver-reference.mdx` (#14036) Remove a broken theme in Cosmic (#14039) Remove stale themes and production sites on 3rd party guides [i18nIgnore] (#14038) Remove deprecated `remarkPlugins` references from "last modified" recipe (#14029) Fix incorrect code examples in the Markdown guide (#14032) i18n(ko-KR): update `db`, `astro-db`, `github`, `session-driver-reference` (#14031) Deprecate `@astrojs/db` (#13986)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes two incorrect code examples in the Markdown guide.
Related issues & labels (optional)