Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Thanks @delucis and @HiDeoo ! I'm just checking in both light and dark, various screen sizes... one initial thing: do you think we still need "More CMS Guides" now that we have both Featured CMS and All CMS? Maybe we don't need "More" at all? Or do we think that's good from an organization/hierarchy standpoint? Just feels like a lot of titles in quick succession! 
|
sarah11918
left a comment
There was a problem hiding this comment.
I checked all the nav guides (to make sure no old logo problems were reintroduced) in Chrome, including at multiple screen sizes, and I think this all looks good to me! (Earlier comment about whether we still need that heading when each separate nav has a heading, but that's a nit and can always be updated later if we decide we don't like it!)
Yeah I also wondered this. I think some kind of separation is good to clarify this is separate from the main content? Doesn’t have to be a heading necessarily though I guess. (We’d need to bump up the heading levels though if we did that.) |
|
I think it's fine for now! Technically, they are both "more". Happy to let you make the call, but it did stand out. |
Description (required)
This PR updates the navigation component for CMS guides to be able to highlight featured platforms from our OSS sponsors. Starting with CloudCannon 🎉