Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
There was a problem hiding this comment.
Thanks so much @tomrcc for providing helpful updates and tweaks here!
I've edited a tiny bit for our style and caught some other nits. In particular, though, see my comments about whether we want to just remove all mention of Bookshop from here if that's not the "first-party, happy path" solution for Astro users. Docs isn't for historical records/curiosities, so happy to make sure we're only showing the most updated, relevant info here!
Comments below (see what you think), and again, thanks for the help with this guide, and for supporting Astro! 🚀
| :::tip | ||
| Also see CloudCannon's [Astro Bookshop integration](https://cloudcannon.com/blog/how-cloudcannons-live-editing-works-with-astro-and-bookshop/) that allows you to add a `bookshop:live` directive to mark any component in your Astro template for live editing. It also allows you to configure live-editable [CloudCannon Snippets](https://cloudcannon.com/documentation/articles/what-is-a-snippet/) for visual editing and page building with components, including in your MDX Markdown content. | ||
| Also see CloudCannon's [Astro Bookshop integration](https://cloudcannon.com/blog/how-cloudcannons-live-editing-works-with-astro-and-bookshop/) that allows you to add a `bookshop:live` directive to mark any component in your Astro template for live editing. It also allows you to configure live-editable [CloudCannon Snippets](https://cloudcannon.com/documentation/articles/what-is-a-snippet/) for visual editing and page building with components, including in your MDX Markdown content. This is how visual editing in CloudCannon worked before being replaced by Editable Regions. | ||
| ::: | ||
|
|
There was a problem hiding this comment.
If this is outdated info, then we can just remove this entirely! (It wasn't clear to me when I prepared this guide whether Bookshop was meant to be the preferred Astro tool nor not, so I added this tip so that we'd have a link to it.) We prefer to show a "happy path" in docs, and not everything that is true needs to be presented. So, do you want this whole tip just gone? Happy to remove!
There was a problem hiding this comment.
This is a bit of a tricky one for us. Since we still have a fair few resources referencing Bookshop, we thought it might be helpful to clear up the difference between ed regions, and bookshop, in case anyone was confused. Now that you bring it up though - it does probably make sense to remove this from your docs, and keep that info on our own docs. If you agree this is best, happy to remove it!
There was a problem hiding this comment.
Yeah, sounds good. Let's remove it here so that new people being introduced to CloudCannon here just never hear about it in the first place, and don't know there's anything to be confused about!
| ## Community Resources | ||
|
|
||
| - Video: [Astro CMS for Visual Editing: Getting Started with CloudCannon](https://www.youtube.com/watch?v=YcH53e1YamE) | ||
| - Video: [Using Bookshop for Visual Editing: Getting Started with CloudCannon](https://www.youtube.com/watch?v=YcH53e1YamE) |
There was a problem hiding this comment.
Are we no longer suggesting Bookshop? If so, happy to also have this removed!
There was a problem hiding this comment.
Yep - if we decide to remove Bookshop references above, perhaps it is best to just remove this.
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
|
Hey @tomrcc ! Super happy to get this merged sooner rather than later for you! I think we're in agreement about taking out stuff, so I'll give the day for you to do it yourself. But if not, I'll just go ahead and do it on your behalf then merge this puppy in before the weekend! 🙌 (Updates can always be made after the fact, if necessary, if I get something wrong!) |
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
|
Hey @sarah11918, apologies for the delayed response. I've decided to remove references to Bookshop entirely, including the rest of that paragraph. Thanks for all your help, have a good weekend! |
sarah11918
left a comment
There was a problem hiding this comment.
Amazing, thank you so much @tomrcc ! Really appreciate your help with this guide, and excited to welcome you to Team Docs! 🥳
Description (required)
Updating the CloudCannon CMS page to
Related issues & labels (optional)