Skip to content

Update required Node version to 18.20.8#11692

Merged
sarah11918 merged 3 commits into5.8.0from
bump-node-18
May 21, 2025
Merged

Update required Node version to 18.20.8#11692
sarah11918 merged 3 commits into5.8.0from
bump-node-18

Conversation

@ascorbic
Copy link
Copy Markdown
Contributor

@ascorbic ascorbic commented May 15, 2025 •
edited
Loading

Description (required)

Updates the minimum Node version to 18.20.8. Adds info to Cloudflare Pages guide about setting the Node version.

The updated requirements are implemented in withastro/astro#13809 and will be released in the next minor

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify
Copy link
Copy Markdown

netlify bot commented May 15, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 46fba95
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/682dbdff1f33330008efd1fa
😎 Deploy Preview https://deploy-preview-11692--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 15, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/deploy/cloudflare.mdx Source changed, localizations will be marked as outdated.
en/guides/deploy/netlify.mdx Source changed, localizations will be marked as outdated.
en/install-and-setup.mdx Source changed, localizations will be marked as outdated.
en/tutorial/1-setup/1.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ascorbic ascorbic added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. labels May 15, 2025
sarah11918
sarah11918 reviewed May 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, Matt! Left some suggestions for maybe simplifying this now that there are more versions to describe.

@ascorbic @sarah11918
Apply suggestions from code review
b04e566 
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
@ascorbic ascorbic added this to the 5.8.0 milestone May 19, 2025
sarah11918
sarah11918 approved these changes May 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Matt!

yanthomasdev
yanthomasdev approved these changes May 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label May 21, 2025
@sarah11918 sarah11918 changed the base branch from main to 5.8.0 May 21, 2025 11:50
@sarah11918 sarah11918 merged commit 276bceb into 5.8.0 May 21, 2025
9 of 10 checks passed
@sarah11918 sarah11918 deleted the bump-node-18 branch May 21, 2025 11:52
@sarah11918 sarah11918 mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Milestone

5.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ascorbic @astrobot-houston @sarah11918 @yanthomasdev