Skip to content

fix: increase minimum Node version to 18.20.8#13809

Merged
ematipico merged 7 commits intomainfrom
node-18-bump
May 22, 2025
Merged

fix: increase minimum Node version to 18.20.8#13809
ematipico merged 7 commits intomainfrom
node-18-bump

Conversation

@ascorbic
Copy link
Copy Markdown
Contributor

@ascorbic ascorbic commented May 15, 2025

Changes

Bumps the required Node version in engines and the CLI

Testing

Tested manually

Docs

Docs will need an update

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 8c30670

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release labels May 15, 2025
github-actions[bot]
github-actions bot previously requested changes May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@ascorbic ascorbic self-assigned this May 15, 2025
@ascorbic ascorbic changed the title fix: increase mininum Node version to 18.20.4 fix: increase minimum Node version to 18.20.4 May 15, 2025
florian-lefebvre
florian-lefebvre reviewed May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few polyfills across core and adapters, that I think can now be removed?

@ascorbic
Copy link
Copy Markdown
Contributor Author

ascorbic commented May 15, 2025

I think most of those require Node 20 before they can be removed

@ascorbic ascorbic changed the title fix: increase minimum Node version to 18.20.4 fix: increase minimum Node version to 18.20.8 May 15, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #13809 will not alter performance

Comparing node-18-bump (8c30670) with main (dfd4ace)

Summary

✅ 6 untouched benchmarks

@florian-lefebvre
Copy link
Copy Markdown
Member

florian-lefebvre commented May 15, 2025

I think most of those require Node 20 before they can be removed

I'm not sure, I think that's @ematipico who proposed to remove them. Do you have more context Ema?

@ascorbic
Copy link
Copy Markdown
Contributor Author

ascorbic commented May 15, 2025

The ones I found were global crypto and File in polyfill.ts. Both were added in Node 19

@ematipico
Copy link
Copy Markdown
Member

ematipico commented May 15, 2025 •
edited
Loading

I discovered that we eventually removed the polyfills we had for stackblitz. The only polyfills left are for File and crypto, and it seems we need Node.js v20. So the PR is fine as is :)

@ematipico
Copy link
Copy Markdown
Member

ematipico commented May 15, 2025

🪖 🐢 🚀

florian-lefebvre
florian-lefebvre approved these changes May 15, 2025
View reviewed changes
@ascorbic ascorbic mentioned this pull request May 15, 2025
Merged
@ascorbic ascorbic modified the milestone: v5.7.0 May 19, 2025
@ascorbic ascorbic added this to the v5.8.0 milestone May 19, 2025
sarah11918
sarah11918 approved these changes May 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changeset for docs!

yanthomasdev
yanthomasdev approved these changes May 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job! 🙌

@ematipico ematipico dismissed github-actions[bot]’s stale review May 22, 2025 10:30

merge day and release day

github-actions[bot]
github-actions bot previously requested changes May 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@ematipico ematipico merged commit 3c3b492 into main May 22, 2025
16 checks passed
@ematipico ematipico deleted the node-18-bump branch May 22, 2025 11:50
@astrobot-houston astrobot-houston mentioned this pull request May 22, 2025
Merged
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
@ascorbic @florian-lefebvre
@ematipico @sarah11918 @yanthomasdev @openscript
fix: increase minimum Node version to 18.20.8 (withastro#13809)
fdee767 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>


Co-authored-by: florian-lefebvre <69633530+florian-lefebvre@users.noreply.github.com>
Co-authored-by: ematipico <602478+ematipico@users.noreply.github.com>
Co-authored-by: sarah11918 <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: yanthomasdev <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@ascorbic ascorbic

Labels

pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) semver: minor Change triggers a `minor` release

Projects

None yet

Milestone

v5.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ascorbic @florian-lefebvre @ematipico @sarah11918 @yanthomasdev