Skip to content

fix(astro-components): update syntax highlighting and add link#11657

Merged
ArmandPhilippot merged 2 commits intowithastro:mainfrom
ArmandPhilippot:fix/syntax-highlighting-astro-components
May 12, 2025
Merged

fix(astro-components): update syntax highlighting and add link#11657
ArmandPhilippot merged 2 commits intowithastro:mainfrom
ArmandPhilippot:fix/syntax-highlighting-astro-components

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

Description (required)

Updates the basics/astro-components.mdx file to:

  • fix a broken syntax highlighting (noticed while updating the French file, in French this is broken... in English this is invisible)
Before After
Broken syntax highlighting before broken syntax highlighting after
  • update a syntax highlighting because the example is describing using slot with Fragment so I think it could be useful to highlight the closing tag too:
Before After
Incomplete syntax highlighting before Incomplete syntax highlighting after
  • add a link to is:inline directive because in HTML components we are referring twice to this directive so newcomers could ask themselves what it is.

Related issues & labels (optional)

  • Suggested label: code snippet update, typo/link/grammar - quick fix!

@ArmandPhilippot ArmandPhilippot added typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. code snippet update Updates a code sample: typo, outdated code etc. labels May 12, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented May 12, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 637361f
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/68224adcaf0e2a000829fe13
😎 Deploy Preview https://deploy-preview-11657--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 12, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/basics/astro-components.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request May 12, 2025
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, and we can use all the help with slot docs we can get! 🚀

@ArmandPhilippot ArmandPhilippot merged commit ad30681 into withastro:main May 12, 2025
10 checks passed
@ArmandPhilippot ArmandPhilippot deleted the fix/syntax-highlighting-astro-components branch May 12, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants