Skip to content

fix: outputs and type in astro-i18n#10797

Merged
ArmandPhilippot merged 2 commits into
withastro:mainfrom
ArmandPhilippot:fix/astro-i18n
Jan 27, 2025
Merged

fix: outputs and type in astro-i18n#10797
ArmandPhilippot merged 2 commits into
withastro:mainfrom
ArmandPhilippot:fix/astro-i18n

Conversation

@ArmandPhilippot

@ArmandPhilippot ArmandPhilippot commented Jan 24, 2025

Copy link
Copy Markdown
Member

Description (required)

  • Fixes the output displayed as comment for getRelativeLocaleUrl("fr") and getAbsoluteLocaleUrl("fr") (missing slash)
  • Fixes the type for getAbsoluteLocaleUrl() (path is optional)

Related issues & labels (optional)

@ArmandPhilippot ArmandPhilippot added typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. code snippet update Updates a code sample: typo, outdated code etc. labels Jan 24, 2025
@netlify

netlify Bot commented Jan 24, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f225f78
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6797f04b9836620008668aa4
😎 Deploy Preview https://deploy-preview-10797--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston

astrobot-houston commented Jan 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/modules/astro-i18n.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 approved these changes Jan 27, 2025
View reviewed changes

@sarah11918 sarah11918 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah! This one got stuck in my "Sarah filters out any PR that has "i18n" in the title 😅

@ArmandPhilippot

ArmandPhilippot commented Jan 27, 2025

Copy link
Copy Markdown
Member Author

Ah yes your list is much shorter during the T&D... Well, it wasn't urgent the doc has been like this for a while! 😄

@ArmandPhilippot ArmandPhilippot merged commit 50fd306 into withastro:main Jan 27, 2025
@ArmandPhilippot ArmandPhilippot deleted the fix/astro-i18n branch January 27, 2025 20:55
@jsparkdev jsparkdev mentioned this pull request Jan 28, 2025
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jan 28, 2025
@thomasbnt
i18n(fr): Update reference/modules/astro-i18n.mdx from withastro#10797
816b18d
@thomasbnt thomasbnt mentioned this pull request Jan 28, 2025
Merged
ArmandPhilippot pushed a commit that referenced this pull request Jan 28, 2025
@thomasbnt
i18n(fr): Update reference/modules/astro-i18n.mdx from #10797 (#10818)
30444eb
@Nin3lee Nin3lee mentioned this pull request Jan 30, 2025
Merged
@iseraph-dev iseraph-dev mentioned this pull request Jun 10, 2026
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

code snippet update Updates a code sample: typo, outdated code etc. typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

getRelativeLocaleUrl/getAbsoluteLocaleUrl with empty path appends trailing slash

3 participants

@ArmandPhilippot @astrobot-houston @sarah11918