Revert "Fix slot regression when there are multiple expressions (#952)"#963
Merged
Princesseuh merged 11 commits intomainfrom Feb 6, 2024
Merged
Revert "Fix slot regression when there are multiple expressions (#952)"#963Princesseuh merged 11 commits intomainfrom
Princesseuh merged 11 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 9d40796 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
martrapp
approved these changes
Feb 6, 2024
ematipico
approved these changes
Feb 6, 2024
natemoo-re
approved these changes
Feb 6, 2024
This was referenced Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#933 ended up causing too many severe regressions so we decided to roll it back until we can do get extensive testing done for the dynamic slot feature.
Testing
Docs
Remove the references of this feature in withastro/docs#6793