Revert "fix(compiler): Support dynamic slot names (#9605)"#9999
Merged
Princesseuh merged 7 commits intomainfrom Feb 6, 2024
Merged
Revert "fix(compiler): Support dynamic slot names (#9605)"#9999Princesseuh merged 7 commits intomainfrom
Princesseuh merged 7 commits intomainfrom
Conversation
This reverts commit 8ce40a4.
🦋 Changeset detectedLatest commit: b4e7cdf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
reviewed
Feb 6, 2024
Princesseuh
approved these changes
Feb 6, 2024
Member
Princesseuh
left a comment
There was a problem hiding this comment.
Unfortunate, we'll get it next time!
… into rollback-dyna-slot
We were expecting the source code to produce an error, but in 2.4.0 of the compiler, that generates valid code
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
We're rolling back the dynamic slots feature in withastro/compiler#963, so I'm reverting changes made in core in this PR
Testing
Docs
Removed mention of the feature in docs withastro/docs#6793