Merged
Conversation
drwpow
commented
Aug 27, 2021
| want{ | ||
| name: "basic (no frontmatter)", | ||
| source: `<button>Click</button>`, | ||
| want: want{ |
Member
Author
There was a problem hiding this comment.
I was just messing around adding these. Dunno if I like em or not
drwpow
commented
Aug 27, 2021
| <body> | ||
| <main> | ||
| <Counter {...someProps} client:visible> | ||
| <h1>Hello React!</h1> |
Member
Author
There was a problem hiding this comment.
This slot, along with the spread props, may be what’s hanging it up? Anyway this test just never completes, which matches what I was seeing from the npm version. Let’s take a look at it next week!
dabc350 to
06d3e27
Compare
e8cbabb to
5073605
Compare
Princesseuh
pushed a commit
that referenced
this pull request
Feb 20, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK I lied; I actually did poke at it a little more when I said I wasn’t gonna. So adding the example from our
examples/framework-reactcode, it actually does hang in the parser so I guess that makes more sense now!