Skip to content

wip: Transform test#4

Merged
natemoo-re merged 8 commits intomainfrom
transform-test
Aug 26, 2021
Merged

wip: Transform test#4
natemoo-re merged 8 commits intomainfrom
transform-test

Conversation

@drwpow
Copy link
Copy Markdown
Member

@drwpow drwpow commented Aug 26, 2021

This adds tests that take an input and expect a certain output. Already found a few bugs, which you can see either in the GitHub checks or by running:

go test -v ./internal/printer

Screen Shot 2021-08-25 at 18 17 47

@drwpow drwpow requested a review from natemoo-re August 26, 2021 00:15
"github.com/snowpackjs/astro/internal/xxhash"
)

func HashFromSource(source string) string {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moved this to a public function so it could be used elsewhere. Not particular about placement.

Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@natemoo-re natemoo-re marked this pull request as ready for review August 26, 2021 23:03
@natemoo-re natemoo-re merged commit 477b892 into main Aug 26, 2021
@natemoo-re natemoo-re deleted the transform-test branch August 26, 2021 23:03
Princesseuh pushed a commit that referenced this pull request Feb 20, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants