Skip to content

Clean up tests#9183

Merged
bluwy merged 1 commit intomainfrom
cleanup-tests
Nov 27, 2023
Merged

Clean up tests#9183
bluwy merged 1 commit intomainfrom
cleanup-tests

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Nov 23, 2023

Changes

  • Remove stray console.log()
  • Make sure tests has .test.js postfix/extension
  • Remove node:test import
  • Rename some test names

Testing

Existing tests should pass.

Docs

n/a. internal refactor.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 23, 2023

⚠️ No Changeset found

Latest commit: 4abdf48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) labels Nov 23, 2023
...config.experimental.i18n,
trailingSlash: 'never',
format: 'directory',
site: 'https://example.com',
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was never run as it didn't have the .test.js postfix. I added it but it failed here, which I fixed it by passing site here.

@bluwy bluwy merged commit 328d999 into main Nov 27, 2023
@bluwy bluwy deleted the cleanup-tests branch November 27, 2023 16:33
matthewp added a commit that referenced this pull request Nov 28, 2023
* feat: implement redesign

* fix: make it build

* feat: visual tweaks

* feat(overlay): update styling, integration endpoint

* feat: add fallback icons

* Clean up tests (#9183)

* Add `@astrojs/upgrade` package for automatic package upgrades (#8525)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* [ci] format

* fix: links with same path but different search params not prefetched (#9189)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* fix: discord icon

* chore: changeset

---------

Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Spencer Whitehead <35475068+SpencerWhitehead7@users.noreply.github.com>
Co-authored-by: Matthew Phillips <matthew@skypack.dev>
ematipico pushed a commit that referenced this pull request Feb 5, 2025
ematipico pushed a commit that referenced this pull request Feb 5, 2025
* feat: implement redesign

* fix: make it build

* feat: visual tweaks

* feat(overlay): update styling, integration endpoint

* feat: add fallback icons

* Clean up tests (#9183)

* Add `@astrojs/upgrade` package for automatic package upgrades (#8525)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* [ci] format

* fix: links with same path but different search params not prefetched (#9189)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* fix: discord icon

* chore: changeset

---------

Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Spencer Whitehead <35475068+SpencerWhitehead7@users.noreply.github.com>
Co-authored-by: Matthew Phillips <matthew@skypack.dev>
ematipico pushed a commit that referenced this pull request Feb 5, 2025
ematipico pushed a commit that referenced this pull request Feb 5, 2025
* feat: implement redesign

* fix: make it build

* feat: visual tweaks

* feat(overlay): update styling, integration endpoint

* feat: add fallback icons

* Clean up tests (#9183)

* Add `@astrojs/upgrade` package for automatic package upgrades (#8525)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* [ci] format

* fix: links with same path but different search params not prefetched (#9189)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* fix: discord icon

* chore: changeset

---------

Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Spencer Whitehead <35475068+SpencerWhitehead7@users.noreply.github.com>
Co-authored-by: Matthew Phillips <matthew@skypack.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants